Closed
Conversation
Classic MinGW has neither InitializeCriticalSectionEx nor GetTickCount64, independent of the target Windows version. Closes
This avoids an ERROR macro clash between <wingdi.h> and <arpa/tftp.h> on MinGW. Closes
vszakats
approved these changes
Oct 8, 2018
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Oct 9, 2018
This avoids an ERROR macro clash between <wingdi.h> and <arpa/tftp.h> on MinGW. Closes curl#3113
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOGDIin addition toWIN32_LEAN_AND_MEANon WindowsGetTickCount64andInitializeCriticalSectionExon classic MinGWThis fixes 1) the MinGW CMake build and 2) MinGW targeting Windows Vista or later.