Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MinGW build #3113

Closed
wants to merge 2 commits into from
Closed

Fix MinGW build #3113

wants to merge 2 commits into from

Conversation

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Oct 8, 2018

  • define NOGDI in addition to WIN32_LEAN_AND_MEAN on Windows
  • don't use GetTickCount64 and InitializeCriticalSectionEx on classic MinGW

This fixes 1) the MinGW CMake build and 2) MinGW targeting Windows Vista or later.

MarcelRaad added 2 commits Oct 7, 2018
Classic MinGW has neither InitializeCriticalSectionEx nor
GetTickCount64, independent of the target Windows version.

Closes
This avoids an ERROR macro clash between <wingdi.h> and <arpa/tftp.h>
on MinGW.

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Oct 9, 2018
This avoids an ERROR macro clash between <wingdi.h> and <arpa/tftp.h>
on MinGW.

Closes curl#3113
@MarcelRaad MarcelRaad closed this in 940e1c1 Oct 9, 2018
@MarcelRaad MarcelRaad deleted the MarcelRaad:fix_mingw_build branch Oct 9, 2018
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Oct 9, 2018

Thanks for the review!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.