Skip to content

Add support for %{stderr} and %{stdout} for --write-out - #3115

Closed
gevaerts wants to merge 1 commit into
curl:masterfrom
gevaerts:master
Closed

gevaerts wants to merge 1 commit into
curl:masterfrom
gevaerts:master

Conversation

@gevaerts

@gevaerts gevaerts commented Oct 8, 2018

Copy link
Copy Markdown
Contributor

Note that the actual stderr test is incomplete: runtests.pl doesn't have easy support for stderr

@jay

jay commented Oct 9, 2018

Copy link
Copy Markdown
Member

I proposed something similar a while ago but it died due to lack of interest, see https://github.com/curl/curl/compare/master...jay:add_flags_to_write-out. Yours is cleaner. In any case one issue is stderr is used for errors and that could disrupt the write-out text. I liked fd 3 - 9 as an alternative even though I couldn't get it working in Windows.

@gevaerts

gevaerts commented Oct 9, 2018

Copy link
Copy Markdown
Contributor Author

My approach is mainly cleaner because it does a lot less... I do like the flexibility of your approach though, and separating output variables from things like this does make sense.

@bagder

bagder commented Oct 19, 2018

Copy link
Copy Markdown
Member

I prefer this version due to its simplicity and minimalism.

@bagder

bagder commented Nov 7, 2018

Copy link
Copy Markdown
Member

Would you mind also removing the TODO entry for this? (18.11)

@gevaerts

gevaerts commented Nov 7, 2018

Copy link
Copy Markdown
Contributor Author

OK, should be done now! (as well as rebased)

@bagder

bagder commented Nov 7, 2018

Copy link
Copy Markdown
Member

Thanks!

@bagder bagder closed this in e431daf Nov 7, 2018
@curl curl deleted a comment from sarankxbczjn Dec 23, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants