Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for %{stderr} and %{stdout} for --write-out #3115

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@gevaerts
Copy link
Contributor

gevaerts commented Oct 8, 2018

Note that the actual stderr test is incomplete: runtests.pl doesn't have easy support for stderr

@jay

This comment has been minimized.

Copy link
Member

jay commented Oct 9, 2018

I proposed something similar a while ago but it died due to lack of interest, see https://github.com/curl/curl/compare/master...jay:add_flags_to_write-out. Yours is cleaner. In any case one issue is stderr is used for errors and that could disrupt the write-out text. I liked fd 3 - 9 as an alternative even though I couldn't get it working in Windows.

@gevaerts

This comment has been minimized.

Copy link
Contributor Author

gevaerts commented Oct 9, 2018

My approach is mainly cleaner because it does a lot less... I do like the flexibility of your approach though, and separating output variables from things like this does make sense.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Oct 19, 2018

I prefer this version due to its simplicity and minimalism.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Nov 7, 2018

Would you mind also removing the TODO entry for this? (18.11)

@gevaerts gevaerts force-pushed the gevaerts:master branch from b225a6e to 8650e81 Nov 7, 2018

@gevaerts

This comment has been minimized.

Copy link
Contributor Author

gevaerts commented Nov 7, 2018

OK, should be done now! (as well as rebased)

@bagder

bagder approved these changes Nov 7, 2018

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Nov 7, 2018

Thanks!

@bagder bagder closed this in e431daf Nov 7, 2018

@curl curl deleted a comment from sarankxbczjn Dec 23, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.