Conversation
Member
|
I proposed something similar a while ago but it died due to lack of interest, see https://github.com/curl/curl/compare/master...jay:add_flags_to_write-out. Yours is cleaner. In any case one issue is stderr is used for errors and that could disrupt the write-out text. I liked fd 3 - 9 as an alternative even though I couldn't get it working in Windows. |
Contributor
Author
|
My approach is mainly cleaner because it does a lot less... I do like the flexibility of your approach though, and separating output variables from things like this does make sense. |
Member
|
I prefer this version due to its simplicity and minimalism. |
Member
|
Would you mind also removing the TODO entry for this? (18.11) |
Contributor
Author
|
OK, should be done now! (as well as rebased) |
bagder
approved these changes
Nov 7, 2018
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the actual stderr test is incomplete: runtests.pl doesn't have easy support for stderr