/ curl Public
openssl: do not log excess "TLS app data" lines for TLS 1.3 #3281
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
The SSL_CTX_set_msg_callback callback is not just called for the
Handshake or Alert protocols, but also for the raw record header
(SSL3_RT_HEADER) and the decrypted inner record type
(SSL3_RT_INNER_CONTENT_TYPE). Be sure to ignore the latter to avoid
excess debug spam when using
curl -vagainst a TLSv1.3-enabled server:
(Following this message, another callback for the decrypted
handshake/alert messages will be be present anyway.)
SSL3_RT_HEADERis only defined since 2012 via openssl/openssl@36b5bb6, otherwise the
ssl_vercheck could have been replaced by
content_type != SSL3_RT_HEADER.
In #2403 (comment), @jay already questioned why this message needs to be logged. For symmetry with ignoring raw record headers, I think dropping the message is a good idea.