Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NTLMv2 #3415

Closed
wants to merge 2 commits into from
Closed

Fix NTLMv2 #3415

wants to merge 2 commits into from

Conversation

huaraz
Copy link

@huaraz huaraz commented Dec 28, 2018

Sorry I broke my branch :-( I hope this is back to the latest

Markus

@huaraz
Copy link
Author

huaraz commented Dec 28, 2018

Failure seems unrelated i.e. test 1556.

TESTDONE: 478 tests out of 479 reported OK: 99%
TESTFAIL: These test cases failed: 1556

Markus

MarcelRaad
MarcelRaad approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much!

@MarcelRaad
Copy link
Member

If there are no objections, I'll merge this for the next release soon.

@danielgustafsson
Copy link
Member

I don't know NTLM so I can't comment on the specifics, but it seems to make sense on the face of it. +1 for merging in this window.

@MarcelRaad MarcelRaad closed this in 7bcca93 Jan 1, 2019
@MarcelRaad
Copy link
Member

Thanks again!

@lock lock bot locked as resolved and limited conversation to collaborators Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huaraz @MarcelRaad @danielgustafsson