multi: support verbose and err stream for conncache closure handle

[jay]

• Change closure handle to receive verbose and error stream settings
  from the easy handle most recently added via curl_multi_add_handle.

The closure handle is a special easy handle used for closing cached
connections. It receives limited settings from the easy handle most
recently added to the multi handle. Prior to this change that did not
include verbose and the error stream which was a problem because on
connection shutdown verbose mode was not acknowledged.

Ref: #3598

Closes #xxxx

[bagder]

The test 1506 output changes seem legit due to the new verbosity.

[jay]

I'm having second thoughts. Does anyone think it will be a problem to copy the stderr FILE stream from the easy handle? What if the handle is removed and the stream is closed or fd reused? That worries me.

[bagder]

Yes I agree. The verbosity level I think is fairly safe but having the stderr pointer survive and "surprise" users after the original transfer is gone I think might lead to unhappiness.

[jay]

test still fails because the order isn't always the same

-* Closing connection 3[CR][LF]
 * Closing connection 1[CR][LF]
+* Closing connection 3[CR][LF]
 * Closing connection 2[CR][LF]

I'm trying strip ^\* Closing connection (?:1|2|3)$ rather than mark it flaky. The 'Closing connection 0' position is needed for the test AFAICS so I can't strip wholesale.

[bagder]

You need to put that strip in the <stripfile> section, and I propose only stripping out the number so we still verify the number of lines. Like this:

diff --git a/tests/data/test1506 b/tests/data/test1506
index 9e440907e..34a72cdf6 100644
--- a/tests/data/test1506
+++ b/tests/data/test1506
@@ -79,19 +79,22 @@ Host: %HOSTIP:%HTTPPORT
 Accept: */*
 
 </protocol>
 <strip>
 ^Host:.*
-^\* Closing connection (?:1|2|3)$
 </strip>
 <file name="log/stderr1506" mode="text">
 * Connection #0 to host server1.example.com left intact
 * Connection #1 to host server2.example.com left intact
 * Connection #2 to host server3.example.com left intact
 * Closing connection 0
 * Connection #3 to host server4.example.com left intact
+* Closing connection
+* Closing connection
+* Closing connection
 </file>
 <stripfile>
 $_ = '' if (($_ !~ /left intact/) && ($_ !~ /Closing connection/))
+s/^(\* Closing connection) [123]/$1/
 </stripfile>
 </verify>
 </testcase>