Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool_cb_wrt: fix bad-function-cast warning #3718

Closed
wants to merge 1 commit into from
Closed

tool_cb_wrt: fix bad-function-cast warning #3718

wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Apr 1, 2019

Commit f5bc578 reintroduced the
warning fixed in commit 2f5f31b.
Extend fhnd's scope and reuse that variable instead of calling
_get_osfhandle a second time to fix the warning again.

Closes
@MarcelRaad
tool_cb_wrt: fix bad-function-cast warning
Verified
This commit was signed with a verified signature.
MarcelRaad Marcel Raad
GPG key ID: FE4D8BC5EE1701DD Learn about signing commits
Loading status checks…
1c224a2 
Commit f5bc578 reintroduced the
warning fixed in commit 2f5f31b.
Extend fhnd's scope and reuse that variable instead of calling
_get_osfhandle a second time to fix the warning again.

Closes
@jay
jay approved these changes Apr 1, 2019
View changes
Copy link
Member

@jay jay left a comment

I guess this is my fault. I didn't see that error in the CI. If the CI passes go for it.
@MarcelRaad MarcelRaad closed this in d110d96 Apr 2, 2019
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Apr 2, 2019

Thanks!
@MarcelRaad MarcelRaad deleted the MarcelRaad:bad_function_cast_warning branch Apr 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jay jay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@MarcelRaad @jay