Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Rename the various authentication clean up functions #3869

Closed
wants to merge 1 commit into from

Conversation

@captain-caveman2k
Copy link
Member

commented May 12, 2019

For consistency and to a avoid confusion.

This has also allowed me to identify that not all calls to the HTTP auth clean up functions need to be the HTTP variant, we can call the underlying auth function directly. For example:

If we are processing a HTTP request (rather than a proxy request) there is no need to clean up the proxy structure and vice versa.

For consistency and to a avoid confusion.
@captain-caveman2k captain-caveman2k deleted the captain-caveman2k:exposure branch May 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.