auth: Rename the various authentication clean up functions - #3869
Closed
captain-caveman2k wants to merge 1 commit into
Closed
auth: Rename the various authentication clean up functions#3869captain-caveman2k wants to merge 1 commit into
captain-caveman2k wants to merge 1 commit into
Conversation
For consistency and to a avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency and to a avoid confusion.
This has also allowed me to identify that not all calls to the HTTP auth clean up functions need to be the HTTP variant, we can call the underlying auth function directly. For example:
If we are processing a HTTP request (rather than a proxy request) there is no need to clean up the proxy structure and vice versa.