lgtm: Exclude FIXME comments from alerts #3876
Conversation
LGTM triggers on FIXME comments issuing alerts for them, which is a bit overzealous as they clutter up the alert list and risk hiding more interesting things from alert-fatigue. Fix by hiding the fixme alerts to let us focus on the more interesting ones. Closes #xxxx
|
I'm not a fan of FIXMEs they seem to hang around indefinitely. I think we should discourage them. I'm not sure if your commit stops that from happening. |
|
I'm rather indifferent. I don't like FIXMEs in the code, but I don't think the lgtm warning makes us remove them... If we really want them removed we add a check to checksrc! =) |
|
I agree that FIXME's tend to never get addressed (in any codebase), so if we want to tackle that we should perhaps turn the ones we have into TODO items and add a checksrc check for them. What I want to achieve with this is however to increase the signal-to-noise ratio in LGTM as they currently are the majority of all alerts (with another one being a false positive). |
They serve very little purpose and mostly just add noise. Most of them have been around for a very long time. I read them all before removing or rephrasing them. Ref: #3876
|
Maybe we can leave this rule in now when I've cleaned up the FIXME situation in the code... |
Agreed, no need to exclude something which should no longer exist. |
LGTM triggers on FIXME comments issuing alerts for them, which is a bit overzealous as they clutter up the alert list and risk hiding more interesting things from alert-fatigue. Fix by hiding the fixme alerts to let us focus on the more interesting ones.
I don't really know if this does what it says on the tin, since I don't know LGTM at all, but the documentation at least implies that it will.