http_ntlm_wb: Fix the error handling to align with that of native/SSPI NTLM

[captain-caveman2k]

The current code doesn't clean up properly on failed authentication attempts nor does it handle a 401 error properly.

These fixes were implemented in the native/SSPI NTLM code in b4d6db8, 50b87c4 and fe6049f but not im the winbind code. As such this patch brings the code up to date.

[jay]

To be clear you are changing state here because you would like to cope with retries better? If there is just NTLM by itself isn't it better to be strict here and error?

[captain-caveman2k]

No - I appreciate my description was a bit misleading. As such I have reworded it.

But in summary this is to align the error handling of the winbind NTLM to that of the native/SSPI behaviour that was missed in to the three commits that I mentioned above.

• The first of which cleans up the handshake correctly on a failure (after a type 1 message) - I missed this in fe20826 but it hadn't been implemented in the winbind code as part of b4d6db8.
• The second cleans up the handshake correctly on a failure (after a type 3 message).
• The third makes sure that the authentication is only performed for a single request.

[captain-caveman2k]

Split into 3 commits to allow the later two to be referenced in the release notes.

You could argue that bd21fc9 should have been in fe20826 really and was my mistake for not digging further.

[jay]

Split into 3 commits to allow the later two to be referenced in the release notes.

Any commit sent upstream ideally should have points of reference, Closes , Fixes , Bug: , Ref: etc. In the future if you're sending multiple commits upstream from a PR (ie not squashing as they're self-contained) it would be helpful to make sure they all have a reference to whatever issue and/or PR so we could find any discussion. Like for example someone bisects and it comes back as xxx it is helpful to know where the issue and PR is to review.

You could argue that bd21fc9 should have been in fe20826 really and was my mistake for not digging further.

We all have had to do follow-ups occasionally, it happens.