Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor: add Visual Studio solution build #3941

Merged
merged 2 commits into from May 29, 2019

Conversation

MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented May 25, 2019

As expected, it fails to link because of #3934 (comment).

@bagder
Copy link
Member

@bagder bagder commented May 25, 2019

Seems if_nametoindex causes problems as presumed:

url.obj : error LNK2019: unresolved external symbol _if_nametoindex@4 referenced in function _zonefrom_url [C:\projects\curl\projects\Windows\VC15\lib\libcurl.vcxproj]

@captain-caveman2k
Copy link
Member

@captain-caveman2k captain-caveman2k commented May 28, 2019

Once #3958 is in this should be go to go ;-)

MarcelRaad added 2 commits May 29, 2019
Introduce BUILD_SYSTEM variable, which is currently always CMake.

Closes curl#3941
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented May 29, 2019

Passing now :-) Will merge once I'm back at a computer.

@MarcelRaad MarcelRaad merged commit 6da44ed into curl:master May 29, 2019
10 of 13 checks passed
@MarcelRaad MarcelRaad deleted the appveyor_build_systems branch May 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants