Changes in Makefile.vc to honor the value passed to ENABLE_OPENSSL_AUTO_LOAD_CONFIG option #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
approved these changes
Jul 3, 2019
sjadhavar
changed the title
vszakats
approved these changes
Jul 4, 2019
Done! |
vszakats
approved these changes
Jul 4, 2019
…TO_LOAD_CONFIG option Currently while building on Windows platform even if we pass the ENABLE_OPENSSL_AUTO_LOAD_CONFIG options with value as "no" it does not set the CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG flag. Made changes so that ENABLE_OPENSSL_AUTO_LOAD_CONFIG will be honored. Also removed some ^M chars from file.
|
Not able to understand why AppVeyor build failed. It was passed earlier. |
malhotrag
approved these changes
Jul 5, 2019
|
Thanks |
caraitto
pushed a commit
to caraitto/curl
that referenced
this pull request
Jul 23, 2019
- Made changes so that ENABLE_OPENSSL_AUTO_LOAD_CONFIG will be honored. - Also removed some ^M chars from file. Prior to this change while building on Windows platform even if we pass the ENABLE_OPENSSL_AUTO_LOAD_CONFIG option with value as "no" it does not set the CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG flag. Closes curl#4086
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently while building on Windows platform even if we pass the ENABLE_OPENSSL_AUTO_LOAD_CONFIG options with value as "no" it does not set the CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG flag.
Made changes so that ENABLE_OPENSSL_AUTO_LOAD_CONFIG will be honored.
Also removed some ^M chars from file.