Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in Makefile.vc to honor the value passed to ENABLE_OPENSSL_AUTO_LOAD_CONFIG option #4086

Closed
wants to merge 1 commit into from

Conversation

@sjadhavar
Copy link

sjadhavar commented Jul 3, 2019

Currently while building on Windows platform even if we pass the ENABLE_OPENSSL_AUTO_LOAD_CONFIG options with value as "no" it does not set the CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG flag.
Made changes so that ENABLE_OPENSSL_AUTO_LOAD_CONFIG will be honored.
Also removed some ^M chars from file.

@danielgustafsson danielgustafsson requested a review from vszakats Jul 3, 2019
@sjadhavar sjadhavar changed the title Changes in Makefile.vc to get the value passed to ENABLE_OPENSSL_AUTO_LOAD_CONFIG option Changes in Makefile.vc to honor the value passed to ENABLE_OPENSSL_AUTO_LOAD_CONFIG option Jul 4, 2019
Copy link
Member

vszakats left a comment

LGTM. Just one minor comment: bumping copyright year to 2019 would be nice.

@sjadhavar

This comment has been minimized.

Copy link
Author

sjadhavar commented Jul 4, 2019

LGTM. Just one minor comment: bumping copyright year to 2019 would be nice.

Done!

…TO_LOAD_CONFIG option

Currently while building on Windows platform even if we pass the ENABLE_OPENSSL_AUTO_LOAD_CONFIG options with value as "no" it does not set the CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG flag.
Made changes so that ENABLE_OPENSSL_AUTO_LOAD_CONFIG will be honored.
Also removed some ^M chars from file.
@sjadhavar

This comment has been minimized.

Copy link
Author

sjadhavar commented Jul 5, 2019

Not able to understand why AppVeyor build failed. It was passed earlier.

@jay jay closed this in 5feb58c Jul 7, 2019
@jay

This comment has been minimized.

Copy link
Member

jay commented Jul 7, 2019

Thanks

caraitto added a commit to caraitto/curl that referenced this pull request Jul 23, 2019
- Made changes so that ENABLE_OPENSSL_AUTO_LOAD_CONFIG will be honored.

- Also removed some ^M chars from file.

Prior to this change while building on Windows platform even if we pass
the ENABLE_OPENSSL_AUTO_LOAD_CONFIG option with value as "no" it does
not set the CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG flag.

Closes curl#4086
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.