Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 encoding in comments #4087

Closed
wants to merge 1 commit into from

Conversation

@ngg
Copy link
Contributor

ngg commented Jul 3, 2019

Some editors and IDEs assume that source files use UTF-8 file encodings.
It also fixes the build with MSVC when /utf-8 command line option is used (this option is mandatory for some other open-source projects, this is useful when using the same options is desired for building all libraries of a project)

@bagder
bagder approved these changes Jul 4, 2019
Copy link
Member

bagder left a comment

... although I would also prefer us to remove individuals names from source code comments...

@jay jay closed this in cf4255c Jul 7, 2019
@jay

This comment has been minimized.

Copy link
Member

jay commented Jul 7, 2019

Thanks

caraitto added a commit to caraitto/curl that referenced this pull request Jul 23, 2019
Some editors and IDEs assume that source files use UTF-8 file encodings.
It also fixes the build with MSVC when /utf-8 command line option is
used (this option is mandatory for some other open-source projects, this
is useful when using the same options is desired for building all
libraries of a project).

Closes curl#4087
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.