Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl.1: Missing lines caused by undefined macros #4111

Closed
wants to merge 1 commit into from
Closed

curl.1: Missing lines caused by undefined macros #4111

wants to merge 1 commit into from

Conversation

ghedo
Copy link
Contributor

@ghedo ghedo commented Jul 13, 2019

Some lines begin with a "'" (apostrophe, single quote), which is then
interpreted as a control character in *roff.

Such lines are interpreted as being a call to a macro, and if
undefined, the lines are removed from the output.

Bug: https://bugs.debian.org/926352
Signed-off-by: Bjarni Ingi Gislason bjarniig@rhi.hi.is


This patch was sent to the Debian bug tracker at https://bugs.debian.org/926352 but it's not Debian-specific.

  Some lines begin with a "'" (apostrophe, single quote), which is then
interpreted as a control character in *roff.

  Such lines are interpreted as being a call to a macro, and if
undefined, the lines are removed from the output.

Bug: https://bugs.debian.org/926352
Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add or improve one of the man page tests to also check and warn for this...

@bagder
Copy link
Member

bagder commented Jul 14, 2019

PR #4113 is meant to detect this problem and once this PR has landed, I can rebase 4113 and make sure it no longer finds these problems and then land that one!

@jay jay closed this in 4c91ab7 Jul 15, 2019
jay pushed a commit that referenced this pull request Jul 15, 2019
@jay
Copy link
Member

jay commented Jul 15, 2019

Thanks

bagder added a commit that referenced this pull request Jul 15, 2019
caraitto pushed a commit to caraitto/curl that referenced this pull request Jul 23, 2019
- Escape apostrophes at line start.

Some lines begin with a "'" (apostrophe, single quote), which is then
interpreted as a control character in *roff.

Such lines are interpreted as being a call to a macro, and if
undefined, the lines are removed from the output.

Bug: https://bugs.debian.org/926352
Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>

Submitted-by: Alessandro Ghedini

Closes curl#4111
caraitto pushed a commit to caraitto/curl that referenced this pull request Jul 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants