Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reserved names in e?hiperfifo.c examples #4153

wants to merge 6 commits into from


Copy link

@b-spencer b-spencer commented Jul 25, 2019

As discussed in #4120 (comment) here is a simple set of fixed to a couple of the example programs that allows them to compile (at least on Linux), and avoids using reserved names.

As far as I can tell, these examples are not built by default (because they have non-universal external dependencies), so they have probably just slightly rotted.

  • _Unused starts with _ and a capital letter, so it's reserved for the toolchain. Avoid that.
  • Lines like (void)_Unused; don't make sense to me and don't compile. Fix that.
  • Just use the classic (void)x; style to mark x as unused, and avoid the whole issue. (Why can't C have C++'s common sense rule of just leaving the arguments unnamed?)

Tested by building these manually on Linux x86_64.

b-spencer added 6 commits Jan 2, 2019
Merge from upstream curl
Pull upstream master
Pull upstream master
Sync fork to original
Merge upstream master
bagder approved these changes Jul 25, 2019
Copy link

@bagder bagder left a comment

please rebase and force-push to make it a single commit that is easier to review!

@jay jay closed this in fd5ab43 Jul 26, 2019
Copy link

@jay jay commented Jul 26, 2019


@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.