Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reserved names in e?hiperfifo.c examples #4153

Closed
wants to merge 6 commits into from

Conversation

@b-spencer
Copy link
Contributor

commented Jul 25, 2019

As discussed in #4120 (comment) here is a simple set of fixed to a couple of the example programs that allows them to compile (at least on Linux), and avoids using reserved names.

As far as I can tell, these examples are not built by default (because they have non-universal external dependencies), so they have probably just slightly rotted.

  • _Unused starts with _ and a capital letter, so it's reserved for the toolchain. Avoid that.
  • Lines like (void)_Unused; don't make sense to me and don't compile. Fix that.
  • Just use the classic (void)x; style to mark x as unused, and avoid the whole issue. (Why can't C have C++'s common sense rule of just leaving the arguments unnamed?)

Tested by building these manually on Linux x86_64.

b-spencer added some commits Jan 2, 2019

Merge pull request #1 from curl/master
Merge from upstream curl
Merge pull request #2 from curl/master
Pull upstream master
Merge pull request #3 from curl/master
Pull upstream master
Merge pull request #4 from curl/master
Sync fork to original
Merge pull request #5 from curl/master
Merge upstream master
@bagder

bagder approved these changes Jul 25, 2019

Copy link
Member

left a comment

please rebase and force-push to make it a single commit that is easier to review!

@jay jay closed this in fd5ab43 Jul 26, 2019

@jay

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.