Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS400: Add CURLOPT_H3 symbols #4185

Closed
wants to merge 1 commit into from
Closed

Conversation

jay
Copy link
Member

@jay jay commented Aug 2, 2019

Follow-up to 3af0e76 which added experimental H3 support.

Closes #xxxx


I'm not sure how HTTP3 support would work with OS400. In particular please take a close look at config-os400.

Follow-up to 3af0e76 which added experimental H3 support.

Closes #xxxx
@jay jay requested a review from monnerat August 2, 2019 18:39
Copy link
Contributor

@monnerat monnerat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coherent with what I've done with other features not supported on OS400. It should compile fine.

To my knowledge, the external libraries needed for H3 are not available for OS400 and will probably never be :-( In case they will, compile scripts would have to be updated accordingly.

However this commit (and related 3af0e76) conflicts with cherry-picks you planned to do in db8ec1f when the feature window would have been opened again.

@bagder
Copy link
Member

bagder commented Aug 3, 2019

The feature window is still open! (Until August 14)

@jay jay closed this in 9a24f97 Aug 4, 2019
@jay
Copy link
Member Author

jay commented Aug 4, 2019

However this commit (and related 3af0e76) conflicts with cherry-picks you planned to do in db8ec1f when the feature window would have been opened again.

Thanks. I will make the adjustments to #4186 now that this has landed.

@jay jay deleted the os400_add_h3_symbols branch August 4, 2019 15:08
@lock lock bot locked as resolved and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants