Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os400: getpeername() and getsockname() return ebcdic AF_UNIX sockaddr, #4214

Closed
wants to merge 1 commit into from

Conversation

@monnerat
Copy link
Contributor

monnerat commented Aug 11, 2019

As libcurl now uses these 2 system functions, wrappers are needed on os400
to convert returned AF_UNIX sockaddrs to ascii.

This is a follow-up to commit 7fb54ef.
See also #4037.

I would appreciate a compilation test prior to commit, maybe by @jonrumsey. Thanks in advance.

@bagder
Copy link
Member

bagder commented Sep 23, 2019

@monnerat this doesn't seem to get any other OS/400 users to review. The question is then mostly if you think we should land this anyway since it is the right way and probably right, or if we should just not do it and wait for the problem to hurt some users who can work on a fix then?

@jonrumsey
Copy link
Contributor

jonrumsey commented Sep 23, 2019

@monnerat , @bagder - Apologies, I missed the original mention notification. I successfully compiled the proposed changes this morning on OS400 V7R2M0.

As libcurl now uses these 2 system functions, wrappers are needed on os400
to convert returned AF_UNIX sockaddrs to ascii.

This is a follow-up to commit 7fb54ef.
See also #4037.
@monnerat
Copy link
Contributor Author

monnerat commented Sep 24, 2019

@bagder: What I am sure is the values returned by these 2 system functions will appear to curl as garbage when applied to unix sockets ! the commit is supposed to fix that.
@jonrumsey: many thanks for confirming it compiles. I will push to master in a few minutes.

@monnerat monnerat closed this in 3e0a8e5 Sep 24, 2019
@monnerat monnerat deleted the monnerat:noebcdic branch Sep 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.