Skip to content

os400: getpeername() and getsockname() return ebcdic AF_UNIX sockaddr,#4214

Closed
monnerat wants to merge 1 commit intocurl:masterfrom
monnerat:noebcdic
Closed

os400: getpeername() and getsockname() return ebcdic AF_UNIX sockaddr,#4214
monnerat wants to merge 1 commit intocurl:masterfrom
monnerat:noebcdic

Conversation

@monnerat
Copy link
Contributor

As libcurl now uses these 2 system functions, wrappers are needed on os400
to convert returned AF_UNIX sockaddrs to ascii.

This is a follow-up to commit 7fb54ef.
See also #4037.

I would appreciate a compilation test prior to commit, maybe by @jonrumsey. Thanks in advance.

@bagder
Copy link
Member

bagder commented Sep 23, 2019

@monnerat this doesn't seem to get any other OS/400 users to review. The question is then mostly if you think we should land this anyway since it is the right way and probably right, or if we should just not do it and wait for the problem to hurt some users who can work on a fix then?

@jonrumsey
Copy link
Contributor

@monnerat , @bagder - Apologies, I missed the original mention notification. I successfully compiled the proposed changes this morning on OS400 V7R2M0.

As libcurl now uses these 2 system functions, wrappers are needed on os400
to convert returned AF_UNIX sockaddrs to ascii.

This is a follow-up to commit 7fb54ef.
See also #4037.
@monnerat
Copy link
Contributor Author

@bagder: What I am sure is the values returned by these 2 system functions will appear to curl as garbage when applied to unix sockets ! the commit is supposed to fix that.
@jonrumsey: many thanks for confirming it compiles. I will push to master in a few minutes.

@monnerat monnerat closed this in 3e0a8e5 Sep 24, 2019
@monnerat monnerat deleted the noebcdic branch September 24, 2019 11:43
@lock lock bot locked as resolved and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants