Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] cookie: curl_filter_cookies public function #4420

Closed
wants to merge 5 commits into from

Conversation

jay
Copy link
Member

@jay jay commented Sep 25, 2019

[WIP] Expose a function to show a list of cookies for a url.

Ref: https://curl.haxx.se/mail/lib-2019-09/0100.html


Filters a linked list of cookies to determine which match the URL. Untested. I already see a few mistakes.

/cc @dhoelzl

@bagder
Copy link
Member

bagder commented Sep 25, 2019

  1. I think that if/when we provide a dedicated cookie match function, it should return the list of matching cookies in a better format than string in netscape format. It is a bit too error prone for users to have to parse that. I think there should be a struct curl_cookie for each cookie to allow the application to get the already parsed details from them.
  2. I don't think the function needs a list of input cookies to set. It just complicates the function.
  3. I think this PR should also provide a basic description of how the function works to make it easier to review and discuss. Possibly done as a wiki page.

@bagder
Copy link
Member

bagder commented Sep 25, 2019

I think the function name should start with curl_cookie_, to group nicer if/when we figure out other cookie-related functions to add.

[WIP] Expose a function to show a list of cookies for a url.

Ref: https://curl.haxx.se/mail/lib-2019-09/0100.html
@jay
Copy link
Member Author

jay commented Sep 25, 2019

Sure, this is to get the ball rolling so that we have a topic. curl_filter_cookies (now curl_cookie_filter) takes cookies obtained with CURLINFO_COOKIELIST as input, filters that input according to url and the filtered list is received as output.

@jay jay added the mothballed label Dec 7, 2019
@jay
Copy link
Member Author

jay commented Dec 7, 2019

I'm mothballing this due to lack of interest.

@jay jay closed this Dec 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants