Update all copyright notices to 2019 on files changed this year#4547
Closed
vilhelmprytz wants to merge 1 commit intocurl:masterfrom
Closed
Update all copyright notices to 2019 on files changed this year#4547vilhelmprytz wants to merge 1 commit intocurl:masterfrom
vilhelmprytz wants to merge 1 commit intocurl:masterfrom
Conversation
Member
|
Thanks! What's particularly interesting to me here is that the checksrc check for exactly this seems broken... |
Member
|
Thanks! With my changes in #4549 I've detected many more mistakes that I'll work on fixing separately. |
jay
pushed a commit
that referenced
this pull request
Nov 8, 2019
- Consider a modified file to be committed this year. - Make the travis CHECKSRC also do COPYRIGHTYEAR scan. - Ignore 0 parents when getting latest commit date of file. since in the CI we're dealing with a truncated repo of last 50 commits, the file's most recent commit may not be available. when this happens git log and rev-list show the initial commit (ie first commit not to be truncated) but that's incorrect so ignore it. Ref: #4547 Closes #4549
bagder
added a commit
that referenced
this pull request
Nov 8, 2019
- Consider a modified file to be committed this year. - Make the travis CHECKSRC also do COPYRIGHTYEAR scan in examples and includes - Ignore 0 parents when getting latest commit date of file. since in the CI we're dealing with a truncated repo of last 50 commits, the file's most recent commit may not be available. when this happens git log and rev-list show the initial commit (ie first commit not to be truncated) but that's incorrect so ignore it. Ref: #4547 Closes #4549 Co-authored-by: Jay Satiro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there were several outdated copyright notices. Most of the files haven't been touched for some time, so I figured I'd update the copyright notices only for files modified during 2019. I don't know the current attitude regarding copyright notices in curl, as far as I can gather the dating pattern is rather scattered throughout the project (some are updated and some are not). Feel free to send any suggestions or flat out reject this PR completely (I can see why this is quite an unnecessary pull request).