Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all copyright notices to 2019 on files changed this year #4547

Closed
wants to merge 1 commit into from

Conversation

@VilhelmPrytz
Copy link
Contributor

VilhelmPrytz commented Oct 31, 2019

I noticed that there were several outdated copyright notices. Most of the files haven't been touched for some time, so I figured I'd update the copyright notices only for files modified during 2019. I don't know the current attitude regarding copyright notices in curl, as far as I can gather the dating pattern is rather scattered throughout the project (some are updated and some are not). Feel free to send any suggestions or flat out reject this PR completely (I can see why this is quite an unnecessary pull request).

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Nov 1, 2019

Thanks! What's particularly interesting to me here is that the checksrc check for exactly this seems broken...

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Nov 2, 2019

Thanks! With my changes in #4549 I've detected many more mistakes that I'll work on fixing separately.

jay added a commit that referenced this pull request Nov 8, 2019
.. because checksrc's copyright year check stopped working.

Ref: #4547

Closes #4549
jay added a commit that referenced this pull request Nov 8, 2019
- Consider a modified file to be committed this year.

- Make the travis CHECKSRC also do COPYRIGHTYEAR scan.

- Ignore 0 parents when getting latest commit date of file.

since in the CI we're dealing with a truncated repo of last 50 commits,
the file's most recent commit may not be available. when this happens
git log and rev-list show the initial commit (ie first commit not to be
truncated) but that's incorrect so ignore it.

Ref: #4547

Closes #4549
bagder added a commit that referenced this pull request Nov 8, 2019
.. because checksrc's copyright year check stopped working.

Ref: #4547

Closes #4549
bagder added a commit that referenced this pull request Nov 8, 2019
- Consider a modified file to be committed this year.

- Make the travis CHECKSRC also do COPYRIGHTYEAR scan in examples and
  includes

- Ignore 0 parents when getting latest commit date of file.

since in the CI we're dealing with a truncated repo of last 50 commits,
the file's most recent commit may not be available. when this happens
git log and rev-list show the initial commit (ie first commit not to be
truncated) but that's incorrect so ignore it.

Ref: #4547

Closes #4549

Co-authored-by: Jay Satiro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.