Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-win32: cpu-machine-OS for Windows on ARM #4590

Closed
wants to merge 2 commits into from

Conversation

@Myriachan
Copy link
Contributor

Myriachan commented Nov 13, 2019

Define the OS macro properly for Windows on ARM builds. Also, we might as well add the GCC-style IA-64 macro.

Define the OS macro properly for Windows on ARM builds.  Also, we might as well add the GCC-style IA-64 macro.
@bagder

This comment has been minimized.

Copy link
Member

bagder commented Nov 13, 2019

Thanks! The added line is too long however:

./config-win32.h:740:93: warning: Longer than 79 columns (LONGLINE)
 #elif defined(_M_ARM_NT) || defined(__arm__) /* ARMv7-Thumb2 (Windows RT, Windows 10 IoT) */
checksrc: 0 errors and 1 warnings
checksrc: 0 errors and 6 warnings suppressed
*** Error code 5
@Myriachan

This comment has been minimized.

Copy link
Contributor Author

Myriachan commented Nov 14, 2019

@bagder I put another changeset in to shorten the line. I don't know why the checks failed; it looks like they're complaining about unrelated problems.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Nov 14, 2019

Agreed!

@bagder
bagder approved these changes Nov 14, 2019
@bagder bagder closed this in c6b70de Nov 14, 2019
@bagder

This comment has been minimized.

Copy link
Member

bagder commented Nov 14, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.