Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOH: provision for using additional dedicated DOH probe slots #4629

Closed
wants to merge 2 commits into from

Conversation

niallor
Copy link

@niallor niallor commented Nov 21, 2019

DOH: provision for using additional dedicated DOH probe slots

The function Curl_doh() uses two dedicated “probe slots” for holding
DOH query state independently for each of the DNS QTYPEs, A and AAAA.
In some use cases, additional host attributes, also available from the DNS,
are needed as connection parameters.

This PR simplifies coding for build-time allocation and run-time
management of extra probe slots which may be needed to hold
query state when retrieving such additional host attributes.

Relates to this posting to the curl-library mailing list.
---- stop ----

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor mistakes to address...

lib/doh.c Outdated Show resolved Hide resolved
lib/doh.c Outdated Show resolved Hide resolved
lib/doh.c Outdated Show resolved Hide resolved
lib/doh.c Outdated Show resolved Hide resolved
@niallor niallor force-pushed the doh-slots branch 3 times, most recently from 3908ea8 to b63fc4f Compare November 25, 2019 17:18
@niallor
Copy link
Author

niallor commented Nov 25, 2019

Changes done, although with far too many commits on account of finger trouble and git knowing best. I may be wrong, but what Travis and Appveyor caught seem to be not my problem.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bagder bagder closed this in 8acfad3 Nov 28, 2019
@bagder
Copy link
Member

bagder commented Nov 28, 2019

Thanks!

@niallor niallor deleted the doh-slots branch November 29, 2019 11:27
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants