NGHTTP2: Add -DNGHTTP2_STATICLIB if static #4670
Conversation
Add NGHTTP2_STATICLIB to compile flags and to the pkg-config if static only since that flag is required to make sure curl pulls the static versions of the symbols. Helps with dependencies to not need to add NGHTTP2_STATICLIB everytime curl is linked.
| @@ -394,6 +394,10 @@ if(USE_NGHTTP2) | |||
| find_package(NGHTTP2 REQUIRED) | |||
| include_directories(${NGHTTP2_INCLUDE_DIRS}) | |||
| list(APPEND CURL_LIBS ${NGHTTP2_LIBRARIES}) | |||
| if(NOT BUILD_SHARED_LIBS) | |||
There was a problem hiding this comment.
Does't BUILD_SHARED_LIBS imply that you build libcurl statically and it doesn't actually say anything about the dependencies?
There was a problem hiding this comment.
Indeed, BUILD_SHARED_LIBS only affects add_library and doesn't affect find_library and other, but I could not think of a better variable to tie it to other than creating a new option, something like STATIC_NGHTTP2 or similar to force static compilation by finding the static libs and cflags, but I am not sure if you guys are fine with adding new cmake options.
I would much prefer to add something like a STATIC_${DEPS} options, but would like to hear feedback about something like that before implementing, especially since it not something that is represented in the configure file.
There was a problem hiding this comment.
Something like 1480c1@37ada3e instead. Although, I am not sure how to do this in automake yet.
There was a problem hiding this comment.
Yes, I figure it could be done with a --enable-static-nghttp2 option in a very similar way.
There was a problem hiding this comment.
Then should I do that instead?
There was a problem hiding this comment.
Well, I'm not convinced it is a terribly motivated change. You could also just invoke CPPFLAGS=-DNGHTTP2_STATICLIB ./configure and then you wouldn't have to change configure at all...
There was a problem hiding this comment.
Whatever you do, please don't tie it to BUILD_SHARED_LIBS. The fact that you want to build static curl does not imply that you want all the dependencies to be static.
| @@ -3315,6 +3317,8 @@ case "$OPT_H2" in | |||
| esac | |||
|
|
|||
| curl_h2_msg="disabled (--with-nghttp2)" | |||
| AM_CONDITIONAL([USE_CPPFLAG_NGHTTP2_STATICLIB], | |||
| [test "x$xc_lt_build_static_only" = 'xyes']) | |||
There was a problem hiding this comment.
Here too, this seems to use the request to build a static-only version of curl to suggest that nghttp2 is also static, which it doesn't say!
|
After running all of my compilation without writing |
Add NGHTTP2_STATICLIB to compile flags and to the pkg-config
if static only since that flag is required to make sure curl
pulls the static versions of the symbols. Helps with dependencies
to not need to add NGHTTP2_STATICLIB everytime curl is linked.
I don't know if the automake sections are correct since I haven't messed with it before.