getinfo: Fix return code for unknown CURLINFO options #468

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@jay
Member
jay commented Oct 1, 2015
  • If a CURLINFO option is unknown return CURLE_UNKNOWN_OPTION.

Prior to this change CURLE_BAD_FUNCTION_ARGUMENT was returned on
unknown. That return value is contradicted by the CURLINFO option
documentation which specifies a return of CURLE_UNKNOWN_OPTION on
unknown.

@jay jay getinfo: Fix return code for unknown CURLINFO options
- If a CURLINFO option is unknown return CURLE_UNKNOWN_OPTION.

Prior to this change CURLE_BAD_FUNCTION_ARGUMENT was returned on
unknown. That return value is contradicted by the CURLINFO option
documentation which specifies a return of CURLE_UNKNOWN_OPTION on
unknown.
acce6ea
@bagder
Member
bagder commented Oct 4, 2015

+1

@jay
Member
jay commented Oct 4, 2015

Thanks for the review, landed in 69ea579.

@jay jay closed this Oct 4, 2015
@jay jay deleted the jay:fix_curlinfo_unknown_option branch Oct 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment