New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getinfo: Fix return code for unknown CURLINFO options #468

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jay
Member

jay commented Oct 1, 2015

  • If a CURLINFO option is unknown return CURLE_UNKNOWN_OPTION.

Prior to this change CURLE_BAD_FUNCTION_ARGUMENT was returned on
unknown. That return value is contradicted by the CURLINFO option
documentation which specifies a return of CURLE_UNKNOWN_OPTION on
unknown.

getinfo: Fix return code for unknown CURLINFO options
- If a CURLINFO option is unknown return CURLE_UNKNOWN_OPTION.

Prior to this change CURLE_BAD_FUNCTION_ARGUMENT was returned on
unknown. That return value is contradicted by the CURLINFO option
documentation which specifies a return of CURLE_UNKNOWN_OPTION on
unknown.
@bagder

This comment has been minimized.

Member

bagder commented Oct 4, 2015

+1

@jay

This comment has been minimized.

Member

jay commented Oct 4, 2015

Thanks for the review, landed in 69ea579.

@jay jay closed this Oct 4, 2015

@jay jay deleted the jay:fix_curlinfo_unknown_option branch Oct 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment