-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngtcp2: Return code for QUIC Connect error #4754
Conversation
I agree a change is needed but I would use a single error code like CURLE_QUIC_CONNECT_ERROR (in the spirit of CURLE_SSL_CONNECT_ERROR) in place of all the CURLE_FAILED_INIT in that file. The INIT error is intended for library initialization errors. This will remain open to gather feedback. It's the holidays and we're in a feature freeze so regardless this won't move forward right away. |
@jay I was also a bit skeptical as SSL is included into Quic... Have a nice Christmas and a happy new year ;) |
@jay Done |
Thanks, Merry Christmas to you as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can change the rest of the CURLE_FAILED_INIT in that file to CURLE_QUIC_CONNECT_ERROR
CIs are failing: strerror.c: In function ‘curl_easy_strerror’: also you'll have to add it to |
Done |
|
Bug: #4754 (comment) Reported-by: Emil Engler
Yes they were missing. I've added them in master, rebased your branch on that and then added CURLE_QUIC_CONNECT_ERROR to os400 as well as a few other changes in description. I have just force-pushed them to your branch. |
@jay Thanks |
I like the new error code. This PR needs a rebase. |
@bagder Rebase done |
Thanks |
Removes some todos.
Adds init code 96 and 97 for Quic (SSL) initialization errors