Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindLibSSH2: add "libssh2" as possible name for library #4804

Closed
wants to merge 1 commit into from

Conversation

@nicoguillier
Copy link
Contributor

@nicoguillier nicoguillier commented Jan 10, 2020

LibSSH2 CMake installation may name the library "libssh2" instead of "ssh2".

On Windows systems, libSSH2 CMake installation may name the library "LibSSH2".
@bagder
Copy link
Member

@bagder bagder commented Jan 10, 2020

When is this necessary?

@nicoguillier
Copy link
Contributor Author

@nicoguillier nicoguillier commented Jan 10, 2020

@jzakrzewski
Copy link
Contributor

@jzakrzewski jzakrzewski commented Jan 10, 2020

I guess this is because of:
https://github.com/libssh2/libssh2/blob/master/src/CMakeLists.txt#L218-L219
On windows there are no standard prefixes for libs, so CMake does not add any when searching. On linux it adds "lib".

@nicoguillier
Copy link
Contributor Author

@nicoguillier nicoguillier commented Jan 10, 2020

@bagder
bagder approved these changes Jan 10, 2020
@jzakrzewski
Copy link
Contributor

@jzakrzewski jzakrzewski commented Jan 10, 2020

I guess it's OK. They use this technique in the official guide:
https://gitlab.kitware.com/cmake/community/-/wikis/doc/tutorials/How-To-Find-Libraries#writing-find-modules (see the CMake code)

@jay jay closed this in 8792a59 Jan 12, 2020
@jay
Copy link
Member

@jay jay commented Jan 12, 2020

Thanks

@nicoguillier
Copy link
Contributor Author

@nicoguillier nicoguillier commented Jan 13, 2020

Thank you all :)

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.