Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for pr 5183 #5186

wants to merge 2 commits into from

test for pr 5183 #5186

wants to merge 2 commits into from


Copy link

@bagder bagder commented Apr 4, 2020

This adds test 1566 that verifies the fix in #5183. It includes the PR commit itself for now as well, but it will be removed once #5183 is merged and this test has proven to work correctly.

Without PR #5183, this test fails.

kwon-young and others added 2 commits April 5, 2020 00:18
Using the --etag-compare option, we can ask the server to either send
the file if it was updated or respond with a 304 response code to
signify that the file did not change.
This commit recognize this response code and avoid writing the output
file, which avoid truncating a previously downloaded file.

This fix issue #5181.
@bagder bagder added the tests label Apr 4, 2020
@bagder bagder closed this in 6bc1040 Apr 5, 2020
@bagder bagder deleted the bagder/test-for-pr-5183 branch April 5, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

2 participants