Closed
Conversation
Using the --etag-compare option, we can ask the server to either send the file if it was updated or respond with a 304 response code to signify that the file did not change. This commit recognize this response code and avoid writing the output file, which avoid truncating a previously downloaded file. This fix issue #5181.
Verifies the fix in #5183
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds test 1566 that verifies the fix in #5183. It includes the PR commit itself for now as well, but it will be removed once #5183 is merged and this test has proven to work correctly.
Without PR #5183, this test fails.