-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of pkcs12 certificate in memory with libcurl setopt v2 #5357
Conversation
7a454db
to
39c2e75
Compare
303b59d
to
b091dbf
Compare
694c6e5
to
a33dd95
Compare
b034ef6
to
5ae8d06
Compare
5ae8d06
to
e815049
Compare
71ca058
to
cf59aa3
Compare
Near all test are successful, except on msys1 mingw64 openssl I have no idea... |
include/curl/easy.h
Outdated
curl_init_blob_flag((structblob), (ptr), (len), CURL_BLOB_DUPFLAG_NOCOPY) | ||
|
||
#define curl_init_blob_dup(structblob, ptr, len) \ | ||
curl_init_blob_flag((structblob), (ptr), (len), CURL_BLOB_DUPFLAG_COPY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Width this very simple struct, do we really need an init macro at all, yet again three different ones? We don't really offer macros in our API before, and you have not provided documentation for these.
Also, why a size_t
for flags? It seems like an non-ideal choice since it can vary in size and is often 64 bits when we have need for a single bit right now...
1501 is a known flaky test on windows. |
1501 should really have the "flaky" keyword then, which it doesn't have now.
|
Probably. I've hesitated because it is only flaky on (appveyor running) Windows, and the We should probably instead make appveyor's CI jobs ignore the results of it. @mback2k, do you think that would make your current Windows CI/tests efforts harder or won't it matter? |
It won't matter, but actually it is not just 1501 that is flaky even though that one hits it more often. I still (again) see the log output missing failures, also on Azure nowadays which is kinda surprising. Edit: actually I already completely disabled test 1501 on the relevant AppVeyor builds due to its extreme flaky state via 4fdb200. |
be81d4b
to
f82f1ae
Compare
It seel they are some error with test561 under Windows I've no idea about this problem... |
dae633b
to
6786759
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a set of minor remarks...
783b152
to
03b7a0c
Compare
Conflicting files: lib/vtls/schannel.c Looks simple enough to fix though! |
03b7a0c
to
c92a862
Compare
done. |
Thanks @gvollant, I'll take it from here. I spotted some minor details I wanted to edit before I merge. |
Thanks @gvollant for your hard work on this! |
Thank you. We don't modify Curl_clone_primary_ssl_config , Curl_free_primary_ssl_config and Curl_ssl_config_matches at beginning of vtls.c I just want be sure this was not needed regards and thank you for working together :-) |
This is the subject of #4679 which somes works (don't merge with current master, by example) |
#6662 is now merged with CA as blob |
This pull request is a reopen of previous pull request, with a lot of modification and confusion
#4371
We can use a PKCS12 certificate with curl, but only from a disk file. We add the feature of using a certificate from memory block without creating temporary file.
This version uses memory blob.
Pehaps a better solution can be use the same logic than POSTFIELD...