Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Support of pkcs12 certificate in memory with libcurl setopt v2 #5357
This pull request is a reopen of previous pull request, with a lot of modification and confusion
We can use a PKCS12 certificate with curl, but only from a disk file. We add the feature of using a certificate from memory block without creating temporary file.
This version uses memory blob.
Probably. I've hesitated because it is only flaky on (appveyor running) Windows, and the
We should probably instead make appveyor's CI jobs ignore the results of it. @mback2k, do you think that would make your current Windows CI/tests efforts harder or won't it matter?
It won't matter, but actually it is not just 1501 that is flaky even though that one hits it more often. I still (again) see the log output missing failures, also on Azure nowadays which is kinda surprising.
Edit: actually I already completely disabled test 1501 on the relevant AppVeyor builds due to its extreme flaky state via 4fdb200.
We don't modify Curl_clone_primary_ssl_config , Curl_free_primary_ssl_config and Curl_ssl_config_matches at beginning of vtls.c
I just want be sure this was not needed
regards and thank you for working together :-)