Rebased version of [WIP] Bundled cacert #4679 #5677
Conversation
|
this PR is probably exclusive with #5664 |
|
Hello, |
gvollant
force-pushed
the
gv_bundled_cacert
branch
from
e7f0319
to
1d9dcbf
Compare
I just rebase it against current master |
|
Note that this still causes test failures (test 1119) which is one of the primary reasons I've not checked it closer yet. |
| return CURLE_SSL_CACERT_BADFILE; | ||
| } | ||
| /* Continue with a warning if no certificate verification is required. */ | ||
| infof(data, "error setting certificate file, continuing anyway\n"); |
There was a problem hiding this comment.
Should we really ignore the failure to load the cacert from memory when we are not verifying the peer certificate?
Would not it be better to fail anyway? Honest question, I don't have a specific opinion on this matter.
|
Closing due to inactivity. |
|
The test failure seems to be related to the SYMBOLS_IN_VERSIONS documentation page. @gvollant @moparisthebest are you guys available to take a look into this? This feature seems very interesting. If not, I should be able to take a look at it later next week. |
|
I rebased https://github.com/gvollant/curl/tree/gv_bundled_cacert but PR is closed... |
|
@gvollant It was closed due to inactivity. It was not reviewed before because the tests were failing: https://github.com/curl/curl/runs/1098854111 |
|
The latest commit must fix test 1119 . How can we reopen ? |
|
cc @bagder |
|
You can't. If you're set to work on it, submit a new PR! |
|
@gvollant let me know if have the time / is planning to open a new PR with the fixes. I'm eager for this feature, if no one is going to keep working on it I should be able to take ownership of the remaining changes needed. |
- New options CURLOPT_CAINFO_BLOB and CURLOPT_PROXY_CAINFO_BLOB to specify in-memory PEM certificates for OpenSSL, Schannel (Windows) and Secure Transport (Apple) SSL backends. Prior to this change PEM certificates could only be imported from a file and not from memory. Co-authored-by: moparisthebest@users.noreply.github.com Ref: #4679 Ref: #5677 Ref: #6109 Closes #6662
I added on my fork https://github.com/gvollant/curl a rebased version of #4679
I invite @moparisthebest on my curl fork. He made the real work
I just wanted a rebased version of this PR to test it against current curl master
Validation : 397e11b [397e11b]
Parents : 4506607
Auteur : moparisthebest admin@moparisthebest.com
Date : vendredi 3 avril 2020 00:32:42
Auteur : moparisthebest
Date de validation : samedi 4 avril 2020 00:31:23
Add CURLOPT_CAINFO_PEM