Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool_doswin: Simplify Windows version detection #5754

Closed
wants to merge 2 commits into from

Conversation

@ccawley2011
Copy link
Contributor

ccawley2011 commented Jul 31, 2020

In addition to the code simplification, this also fixes running the tool on Windows 9x.

@MarcelRaad
Copy link
Member

MarcelRaad commented Aug 1, 2020

Thanks, looks good to me. Out of curiosity, do you actually build for Windows 9x?

@ccawley2011
Copy link
Contributor Author

ccawley2011 commented Aug 2, 2020

Thanks, looks good to me. Out of curiosity, do you actually build for Windows 9x?

I did test with Windows 98 SE, and it works fine with this PR.

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Aug 2, 2020
Closes curl#5754
@MarcelRaad MarcelRaad closed this in 790137b Aug 2, 2020
@ccawley2011 ccawley2011 deleted the ccawley2011:version_win32 branch Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.