Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Use new issue template feature #5936

Closed
wants to merge 1 commit into from

Conversation

@emilengler
Copy link
Contributor

@emilengler emilengler commented Sep 8, 2020

This helps us to avoid getting feature requests as well as security
bugs reported into the issue tracker.

emilengler added a commit to emilengler/curl that referenced this pull request Sep 8, 2020
This helps us to avoid getting feature requests as well as security
bugs reported into the issue tracker.

Closes curl#5936
@emilengler emilengler force-pushed the emilengler:2020-09-issue-template branch from 0409e55 to c95adc2 Sep 8, 2020
@mback2k
Copy link
Member

@mback2k mback2k commented Sep 8, 2020

Instead of providing templates with these warnings it is also possible to directly link to the corresponding pages, eg.:
https://github.com/home-assistant/core/blob/dev/.github/ISSUE_TEMPLATE/config.yml

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 8, 2020

Instead of providing templates with these warnings it is also possible to directly link to the corresponding pages, eg.:

https://github.com/home-assistant/core/blob/dev/.github/ISSUE_TEMPLATE/config.yml

Thanks, TIL

emilengler added a commit to emilengler/curl that referenced this pull request Sep 9, 2020
This helps us to avoid getting feature requests as well as security
bugs reported into the issue tracker.

Closes curl#5936
@emilengler emilengler force-pushed the emilengler:2020-09-issue-template branch from c95adc2 to c88584c Sep 9, 2020
@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 9, 2020

Fixed. Now security redirects to hackerone and feature request to the ML.
I think this is ready for merge

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 9, 2020

I think it's fine to leave the comments in the bug_report.md file though

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 9, 2020

emilengler added a commit to emilengler/curl that referenced this pull request Sep 9, 2020
This helps us to avoid getting feature requests as well as security
bugs reported into the issue tracker.

Closes curl#5936
@emilengler emilengler force-pushed the emilengler:2020-09-issue-template branch from c88584c to 4a739bc Sep 9, 2020
@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 9, 2020

@mback2k Adjustments applied

@bagder
Copy link
Member

@bagder bagder commented Sep 9, 2020

That test link isn't showing the latest update, does it?

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 10, 2020

That test link isn't showing the latest update, does it?

Nope but it's only a text change. I can't update it from here unfortunately. I am on the ride

@bagder
Copy link
Member

@bagder bagder commented Sep 11, 2020

Because it still says "ML" and not "mailing list".

Create a report to help us improve

Proposal:

Report a bug, mistake or problem you've found in curl or libcurl, as detailed as possible.

This is only for bugs! Feature requests should go to the ML

Proposal:

To propose new features or enhancements, please bring that discussion to a suitable curl mailing list.

Please report the issue according to our security policy

Proposal:

Please report security problems or just suspected security problems to the curl-security team, to allow us to assess and work on it privately before we release a fix and inform the public.

@bagder
Copy link
Member

@bagder bagder commented Sep 14, 2020

Fourth entry "Question" and instruct that questions should be taken to a dedicated mailing list.

A possible fifth entry could be "Commercial support" and saying that if the user is interested in hiring/paying someone for support, we provide alternatives on https://curl.haxx.se/support.html

emilengler added a commit to emilengler/curl that referenced this pull request Sep 14, 2020
This helps us to avoid getting feature requests as well as security
bugs reported into the issue tracker.

Closes curl#5936
@emilengler emilengler force-pushed the emilengler:2020-09-issue-template branch from 4a739bc to 4b0cf6d Sep 14, 2020
@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 14, 2020

I implemented @bagder's proposals

@bagder
Copy link
Member

@bagder bagder commented Sep 15, 2020

Awesome, can you refresh your example URL so that we can see how this looks "live" ?

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 15, 2020

Awesome, can you refresh your example URL so that we can see how this looks "live" ?

Yes I will do this in the afternoon!

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 15, 2020

@bagder Updated

This helps us to avoid getting feature requests as well as security
bugs reported into the issue tracker.

Closes #5936
@emilengler emilengler force-pushed the emilengler:2020-09-issue-template branch from 4b0cf6d to 5942062 Sep 15, 2020
@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Sep 16, 2020

I think this is ready for merge now, the demo is also updated

@bagder
bagder approved these changes Sep 16, 2020
@bagder bagder requested review from mback2k and jay Sep 16, 2020
url: https://curl.haxx.se/mail/
about: To propose new features or enhancements, please bring that discussion to a suitable curl mailing list.
- name: Security vulnerability
url: https://hackerone.com/curl

This comment has been minimized.

@mback2k

mback2k Sep 16, 2020
Member

Would it make sense to link to https://curl.haxx.se/dev/secprocess.html instead?

This comment has been minimized.

@bagder

bagder Sep 16, 2020
Member

I don't think so. The secprocess page is more about describing how we approach it, if someone wants to report an issue I figured the hackerone page is more direct.

@jay
Copy link
Member

@jay jay commented Sep 17, 2020

There's some talk earlier about a demo, how do I access that?

@jay
jay approved these changes Sep 17, 2020
@bagder
Copy link
Member

@bagder bagder commented Sep 17, 2020

Thanks!

@bagder bagder closed this in 48fb543 Sep 17, 2020
@bagder
Copy link
Member

@bagder bagder commented Sep 17, 2020

Hm, annoyingly enough it seems GitHub adds an extra "Report a security vulnerability" by itself:
Screenshot_2020-09-17 curl curl

I guess we need to remove our own version of it then ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.