Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format specifiers #6241

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/http.c
Expand Up @@ -4003,7 +4003,7 @@ CURLcode Curl_http_readwrite_headers(struct Curl_easy *data,
infof(data, "Illegal STS header skipped\n");
#ifdef DEBUGBUILD
else
infof(data, "Parsed STS header fine (%d entries)\n",
infof(data, "Parsed STS header fine (%zu entries)\n",
data->hsts->list.size);
#endif
}
Expand Down
4 changes: 2 additions & 2 deletions lib/http2.c
Expand Up @@ -2070,7 +2070,7 @@ static ssize_t http2_send(struct connectdata *conn, int sockindex,

if(acc > MAX_ACC) {
infof(conn->data, "http2_send: Warning: The cumulative length of all "
"headers exceeds %zu bytes and that could cause the "
"headers exceeds %d bytes and that could cause the "
"stream to be rejected.\n", MAX_ACC);
}
}
Expand Down Expand Up @@ -2269,7 +2269,7 @@ CURLcode Curl_http2_switched(struct connectdata *conn,
data into stream->mem, overwriting data already there. */
if(H2_BUFSIZE < nread) {
failf(data, "connection buffer size is too small to store data following "
"HTTP Upgrade response header: buflen=%zu, datalen=%zu",
"HTTP Upgrade response header: buflen=%d, datalen=%zu",
H2_BUFSIZE, nread);
return CURLE_HTTP2;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/ldap.c
Expand Up @@ -923,7 +923,7 @@ static int _ldap_url_parse2(const struct connectdata *conn, LDAPURLDesc *ludp)
char *unescaped;
CURLcode result;

LDAP_TRACE(("attr[%d] '%s'\n", i, attributes[i]));
LDAP_TRACE(("attr[%zu] '%s'\n", i, attributes[i]));

/* Unescape the attribute */
result = Curl_urldecode(conn->data, attributes[i], 0, &unescaped, NULL,
Expand Down
4 changes: 2 additions & 2 deletions lib/socks_gssapi.c
Expand Up @@ -493,7 +493,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
gss_release_buffer(&gss_status, &gss_recv_token);

if(gss_w_token.length != 1) {
failf(data, "Invalid GSS-API encryption response length (%d).",
failf(data, "Invalid GSS-API encryption response length (%zu).",
gss_w_token.length);
gss_release_buffer(&gss_status, &gss_w_token);
gss_delete_sec_context(&gss_status, &gss_context, NULL);
Expand All @@ -505,7 +505,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
}
else {
if(gss_recv_token.length != 1) {
failf(data, "Invalid GSS-API encryption response length (%d).",
failf(data, "Invalid GSS-API encryption response length (%zu).",
gss_recv_token.length);
gss_release_buffer(&gss_status, &gss_recv_token);
gss_delete_sec_context(&gss_status, &gss_context, NULL);
Expand Down
4 changes: 2 additions & 2 deletions lib/vquic/ngtcp2.c
Expand Up @@ -1571,7 +1571,7 @@ static CURLcode http_request(struct connectdata *conn, const void *mem,

if(acc > MAX_ACC) {
infof(data, "http_request: Warning: The cumulative length of all "
"headers exceeds %zu bytes and that could cause the "
"headers exceeds %d bytes and that could cause the "
"stream to be rejected.\n", MAX_ACC);
}
}
Expand Down Expand Up @@ -1741,7 +1741,7 @@ static CURLcode ng_process_ingress(struct connectdata *conn,
if(SOCKERRNO == EAGAIN || SOCKERRNO == EWOULDBLOCK)
break;

failf(conn->data, "ngtcp2: recvfrom() unexpectedly returned %d", recvd);
failf(conn->data, "ngtcp2: recvfrom() unexpectedly returned %zd", recvd);
return CURLE_RECV_ERROR;
}

Expand Down
6 changes: 3 additions & 3 deletions lib/vquic/quiche.c
Expand Up @@ -358,7 +358,7 @@ static CURLcode process_ingress(struct connectdata *conn, int sockfd,
break;

if(recvd < 0) {
failf(conn->data, "quiche: recv() unexpectedly returned %d "
failf(conn->data, "quiche: recv() unexpectedly returned %zd "
"(errno: %d, socket %d)", recvd, SOCKERRNO, sockfd);
return CURLE_RECV_ERROR;
}
Expand All @@ -368,7 +368,7 @@ static CURLcode process_ingress(struct connectdata *conn, int sockfd,
break;

if(recvd < 0) {
failf(conn->data, "quiche_conn_recv() == %d", recvd);
failf(conn->data, "quiche_conn_recv() == %zd", recvd);
return CURLE_RECV_ERROR;
}
} while(1);
Expand Down Expand Up @@ -762,7 +762,7 @@ static CURLcode http_request(struct connectdata *conn, const void *mem,

if(acc > MAX_ACC) {
infof(data, "http_request: Warning: The cumulative length of all "
"headers exceeds %zu bytes and that could cause the "
"headers exceeds %d bytes and that could cause the "
"stream to be rejected.\n", MAX_ACC);
}
}
Expand Down
4 changes: 2 additions & 2 deletions lib/vssh/libssh2.c
Expand Up @@ -1265,7 +1265,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block)
a time-out or similar */
result = CURLE_SSH;
sshc->actualcode = result;
DEBUGF(infof(data, "error = %d makes libcurl = %d\n",
DEBUGF(infof(data, "error = %lu makes libcurl = %d\n",
sftperr, (int)result));
state(conn, SSH_STOP);
break;
Expand Down Expand Up @@ -1945,7 +1945,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block)
sshc->actualcode = CURLE_SSH;
sftperr = LIBSSH2_FX_OK;
}
failf(data, "Upload failed: %s (%d/%d)",
failf(data, "Upload failed: %s (%lu/%d)",
sftperr != LIBSSH2_FX_OK ?
sftp_libssh2_strerror(sftperr):"ssh error",
sftperr, rc);
Expand Down
4 changes: 2 additions & 2 deletions lib/vtls/sectransp.c
Expand Up @@ -1970,7 +1970,7 @@ static CURLcode sectransp_connect_step1(struct connectdata *conn,
else {
CURLcode result;
ssl_sessionid =
aprintf("%s:%d:%d:%s:%hu", ssl_cafile,
aprintf("%s:%d:%d:%s:%ld", ssl_cafile,
verifypeer, SSL_CONN_CONFIG(verifyhost), hostname, port);
ssl_sessionid_len = strlen(ssl_sessionid);

Expand Down Expand Up @@ -2189,7 +2189,7 @@ static CURLcode verify_cert(const char *cafile, struct Curl_easy *data,
if(res < 0) {
free(certbuf);
CFRelease(array);
failf(data, "SSL: invalid CA certificate #%d (offset %d) in bundle",
failf(data, "SSL: invalid CA certificate #%d (offset %zu) in bundle",
n, offset);
return CURLE_SSL_CACERT_BADFILE;
}
Expand Down
4 changes: 2 additions & 2 deletions src/tool_progress.c
Expand Up @@ -227,11 +227,11 @@ bool progress_meter(struct GlobalConfig *global,
}
if(dlknown && all_dltotal)
/* TODO: handle integer overflow */
msnprintf(dlpercen, sizeof(dlpercen), "%3d",
msnprintf(dlpercen, sizeof(dlpercen), "%3" CURL_FORMAT_CURL_OFF_T,
all_dlnow * 100 / all_dltotal);
if(ulknown && all_ultotal)
/* TODO: handle integer overflow */
msnprintf(ulpercen, sizeof(ulpercen), "%3d",
msnprintf(ulpercen, sizeof(ulpercen), "%3" CURL_FORMAT_CURL_OFF_T,
all_ulnow * 100 / all_ultotal);

/* get the transfer speed, the higher of the two */
Expand Down
2 changes: 1 addition & 1 deletion tests/libtest/lib1558.c
Expand Up @@ -49,7 +49,7 @@ int test(char *URL)
goto test_cleanup;
}

printf("Protocol: %x\n", protocol);
printf("Protocol: %lx\n", protocol);

curl_easy_cleanup(curl);
curl_global_cleanup();
Expand Down
2 changes: 1 addition & 1 deletion tests/libtest/lib1915.c
Expand Up @@ -63,7 +63,7 @@ static CURLSTScode hstswrite(CURL *easy, struct curl_hstsentry *e,
{
(void)easy;
(void)userp;
printf("[%u/%u] %s %s\n", i->index, i->total, e->name, e->expire);
printf("[%zu/%zu] %s %s\n", i->index, i->total, e->name, e->expire);
return CURLSTS_OK;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/unit1660.c
Expand Up @@ -152,7 +152,7 @@ UNITTEST_START
showsts(e, chost);
}

printf("Number of entries: %d\n", h->list.size);
printf("Number of entries: %zu\n", h->list.size);

/* verify that it is exists for 7 seconds */
chost = "expire.example";
Expand Down