Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: "Remove" duplicate function #6249

Closed

Conversation

@emilengler
Copy link
Contributor

@emilengler emilengler commented Nov 25, 2020

file_disconnect() is identical with file_do() except the function header
but as the arguments are unused anyway why not just return file_do()
directly? This will make the binary smaller and the code more readable.

file_disconnect() is identical with file_do() except the function header
but as the arguments are unused anyway why not just return file_do()
directly? This will make the binary smaller and the code more readable.
@bagder
bagder approved these changes Nov 25, 2020
Copy link
Member

@bagder bagder left a comment

Nice catch!

@bagder
Copy link
Member

@bagder bagder commented Nov 25, 2020

thanks!

@bagder bagder closed this in 12cb7a1 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants