Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtcp2: Fix build error due to symbol name change #6271

Closed
wants to merge 1 commit into from

Conversation

@jay
Copy link
Member

@jay jay commented Dec 2, 2020

  • s/NGTCP2_CRYPTO_LEVEL_APP/NGTCP2_CRYPTO_LEVEL_APPLICATION/g

ngtcp2/ngtcp2@76232e9 changed the name.

Closes #xxxx


http3 builds in CI broke today due to symbol rename in ngtcp2 so I propose we change the name here too. Unfortunately with this change users that build with old ngtcp2 will then get build errors...

- s/NGTCP2_CRYPTO_LEVEL_APP/NGTCP2_CRYPTO_LEVEL_APPLICATION/g

ngtcp2/ngtcp2@76232e9 changed the name.

Closes #xxxx
@jay jay added the HTTP/3 label Dec 2, 2020
@jay jay requested review from bagder and tatsuhiro-t Dec 2, 2020
@bagder
Copy link
Member

@bagder bagder commented Dec 2, 2020

Unfortunately with this change users that build with old ngtcp2 will then get build errors

Yes. This goes for all our HTTP/3 builds until at least parts of those builds are done with release versions of the involved libraries. Until then, we just keep up with the development versions.

@bagder
bagder approved these changes Dec 2, 2020
Copy link
Member

@bagder bagder left a comment

Yeps, matches ngtcp2/ngtcp2@76232e9

@jay jay closed this in 2d1df66 Dec 2, 2020
@jay jay deleted the jay:fix_http3_ci branch Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants