djgpp: build fixes#6382
Conversation
Allow 'Makefile.dist' to build both 'lib' and 'src'.
*) Allow using the Windows hosted djgpp cross compiler
to build for MSDOS under Windows.
*) 'USE_SSL' -> 'USE_OPENSSL'.
*) Added a 'link_EXE' macro. Etc, etc.
*) Linking 'curl.exe' needs '$(CURLX_CFILES)' too. *) Do not pick-up '../lib/djgpp/*.o' files. Recompile locally. *) Generate a gzipped 'tool_hugehelp.c' if 'USE_ZLIB=1'.
Add another 'make' procedure.
|
|
||
| # | ||
| # Use zlib for contents encoding | ||
| # Use zlib for contents encoding. Needed for 'USE_OPENSSL=1' too. |
There was a problem hiding this comment.
Since when is zlib needed for OpenSSL?
There was a problem hiding this comment.
It could be when perl Configure enable-zlib is used (what I used last time I built OpenSSL with djgpp).
No use of zlib.dll on MSDOS you know.
There was a problem hiding this comment.
It could be when
perl Configure enable-zlibis used (what I used last time I built OpenSSL with djgpp).
Then I think you could say something like # May be needed if using static OpenSSL built with zlib enabled.
There was a problem hiding this comment.
Okay. But how about the syntax USE_ZLIB ?= 0. So one could do a make -f Makefile.dj USE_ZLIB=1 clean all.
There was a problem hiding this comment.
But how about the syntax
USE_ZLIB ?= 0
They should probably all be like that since there is no configure script
Previous warnings related to AFL fuzzy-functions are gone. Hence no need for that.
Clarify the 'conditional variable assignment' in 'common.dj'.
jay
added
feature-window
|
Thanks. I landed this now because IMO djgpp build is broken without it so I see no point in waiting until the next release. I was not able to work with this PR the traditional way, it says it's from "unknown repository". Where is your curl fork? For posterity I'll note found a workaround, that I'm sure to forget. I added .patch to the URL then git am'd it, like this then I squashed all the commits into one via interactive rebase (so I could combine and edit all the commit messages), fetched upstream, rebased on upstream/master, checkout my master, merge --ff-only, review then push upstream. |
Sorry about that. I messed up my fork and hence deleted it. I'm still very little into these more advanced Git commands. |
2 participants
Here are some fixes for
lib/Makefile.dj,src/Makefile.djand somepackages/DOS/files.Not many are using djgpp nowadays, but I've had these changes locally for ages. So now hopefully the diffs are out of the way.