Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a lot of conn->data uses #6425

Closed
wants to merge 1 commit into from
Closed

Remove a lot of conn->data uses #6425

wants to merge 1 commit into from

Commits on Jan 15, 2021

  1. lib: pass in 'struct Curl_easy *' to most functions 

    ... in most cases instead of 'struct connectdata *' but in some cases in
addition to.

- We mostly operate on transfers and not connections.

- We need the transfer handle to log, store data and more. Everything in
  libcurl is driven by a transfer (the CURL * in the public API).

- This work clarifies and separates the transfers from the connections
  better.

- We should avoid "conn->data". Since individual connections can be used
  by many transfers when multiplexing, making sure that conn->data
  points to the current and correct transfer at all times is difficult
  and has been notoriously error-prone over the years. The goal is to
  ultimately remove the conn->data pointer for this reason.

Closes #6425
    @bagder
    bagder committed Jan 15, 2021
    Copy the full SHA
    d0cceac View commit details
    Browse the repository at this point in the history