lib: use int type for more port variables

[jay]

This is a follow-up to 764c6bd. Prior to that change port variables
were usually type long.

Closes #xxxx

---

Note that 764c6bd changed Curl_conninfo_remote to use a local port variable and not assign to conn->port... I'm not sure why that is, I think it should be conn->port shouldn't it?

[ghost]

Congratulations 🎉. DeepCode analyzed your code in 26.992 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

[jay]

I need the question addressed before I land:

curl/lib/connect.c

Lines 693 to 703 in 796ce29

	long port;
	plen = sizeof(struct Curl_sockaddr_storage);
	memset(&ssrem, 0, sizeof(ssrem));
	if(getpeername(sockfd, (struct sockaddr*) &ssrem, &plen)) {
	int error = SOCKERRNO;
	failf(data, "getpeername() failed with errno %d: %s",
	error, Curl_strerror(error, buffer, sizeof(buffer)));
	return;
	}
	if(!Curl_addr2string((struct sockaddr*)&ssrem, plen,
	conn->primary_ip, &port)) {

I turned that into int port but is that even necessary, shouldn't it be &conn->port (which is also int)?

[bagder]

conn->port should already be populated with the correct port number so this is just a way to not write it again (from 764c6bd)