Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test1188: Test for 'empty reply' error message #6637

Closed
wants to merge 1 commit into from

Conversation

@jay
Copy link
Member

@jay jay commented Feb 19, 2021

  • Test for an empty reply error message instead of non-existent host.

Some ISPs hijack DNS and resolve non-existent hosts.

Ref: https://en.wikipedia.org/wiki/DNS_hijacking#Manipulation_by_ISPs
Ref: #6621
Ref: #6623

Closes #xxxx

@jay jay added the tests label Feb 19, 2021
@bagder
bagder approved these changes Feb 19, 2021
Copy link
Member

@bagder bagder left a comment

Ack yes...

@bagder
Copy link
Member

@bagder bagder commented Feb 19, 2021

Another option could be to use -f and have the server respond with a 4xx.

- Change the test to check for curl error on HTTP 404 Not Found.

test1188 tests "--write-out with %{onerror} and %{urlnum} to stderr".
Prior to this change it did that by specifying a non-existent host which
would cause an error. ISPs may hijack DNS and resolve non-existent hosts
so the test would not work if that was the case.

Ref: https://en.wikipedia.org/wiki/DNS_hijacking#Manipulation_by_ISPs
Ref: #6621
Ref: #6623

Closes #xxxx
@jay jay force-pushed the jay:change_test1188 branch from f25ade1 to 2a6885d Feb 20, 2021
@jay jay closed this in 3d954e4 Feb 20, 2021
@jay jay deleted the jay:change_test1188 branch Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants