Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: avoid fallthrough cases in switch statements #7322

Commits on Sep 26, 2021

  1. lib: avoid fallthrough cases in switch statements

    Commit b5a434f inhibits the warning
    on implicit fallthrough cases, since the current coding of indicating
    fallthrough with comments is falling out of fashion with new compilers.
    This attempts to make the issue smaller by rewriting fallthroughs to no
    longer fallthrough, via either breaking the cases or turning switch
    statements into if statements.
    
      lib/content_encoding.c: the fallthrough codepath is simply copied
        into the case as it's a single line.
      lib/http_ntlm.c: the fallthrough case skips a state in the state-
        machine and fast-forwards to NTLMSTATE_LAST. Do this before the
        switch statement instead to set up the states that we actually
        want.
      lib/http_proxy.c: the fallthrough is just falling into exiting the
        switch statement which can be done easily enough in the case.
      lib/mime.c: switch statement rewritten as if statement.
      lib/pop3.c: the fallthrough case skips to the next state in the
        statemachine, do this explicitly instead.
      lib/urlapi.c: switch statement rewritten as if statement.
      lib/vssh/wolfssh.c: the fallthrough cases fast-forwards the state
        machine, do this by running another iteration of the switch
        statement instead.
      lib/vtls/gtls.c: switch statement rewritten as if statement.
      lib/vtls/nss.c: the fallthrough codepath is simply copied into the
        case as it's a single line. Also twiddle a comment to not be
        inside a non-brace if statement.
    
    Closes: #xxxx
    See-also: curl#7295
    danielgustafsson committed Sep 26, 2021
    Copy the full SHA
    cd05efa View commit details
    Browse the repository at this point in the history