Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: align make and test flags in various config files #7591

Closed
wants to merge 1 commit into from
Closed

CI: align make and test flags in various config files #7591

wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Aug 19, 2021

  1. Remove redundant parameters -a -p from target test-nonflaky.
  2. Disable testing of SCP protocol for all Windows environments.
  3. Use Makefile target to run tests in autotools builds on AppVeyor.
  4. Make sure we also compile the examples on all touched CIs.
  5. Don't use -vc parameter which is reserved for debugging.

@mback2k mback2k self-assigned this Aug 19, 2021
@mback2k mback2k added CI Continuous Integration tests labels Aug 19, 2021
@mback2k mback2k mentioned this pull request Aug 19, 2021
Open
@mback2k
CI: align make and test flags in various config files
0123a0e 
1. Remove redundant parameters -a -p from target test-nonflaky.
2. Disable testing of SCP protocol for all Windows environments.
3. Use Makefile target to run tests in autotools builds on AppVeyor.
4. Make sure we also compile the examples on all touched CIs.
5. Don't use -vc parameter which is reserved for debugging.
6. Enable verbose make output on all touched CIs.

Closes curl#7591
@mback2k
Copy link
Member Author

mback2k commented Aug 20, 2021

@jay @MarcelRaad hey you CURL_FORMAT_CURL_OFF_T experts, do you have any idea why the examples using fprintf cannot compile on the failed Azure DevOps builds? In the curl library source code itself it is used in exactly the same way without such compilation issues:

anyauthput.c: In function 'read_callback':
anyauthput.c:93:19: error: ISO C does not support the 'I' printf flag [-Werror=format=]
   93 |   fprintf(stderr, "*** We read %" CURL_FORMAT_CURL_OFF_T
      |                   ^~~~~~~~~~~~~~~
anyauthput.c:93:19: error: format '%d' expects argument of type 'int', but argument 3 has type 'curl_off_t' {aka 'long long int'} [-Werror=format=]
In file included from ../../include/curl/curl.h:38,
                 from anyauthput.c:32:
../../include/curl/system.h:199:42: note: format string is defined here
  199 | #  define CURL_FORMAT_CURL_OFF_T     "I64d"

@jay
Copy link
Member

jay commented Aug 22, 2021

do you have any idea why the examples using fprintf cannot compile on the failed Azure DevOps builds?

It looks like warnings are treated as errors but I don't know why it's an error for just the examples. I found this post from you many years ago, and maybe we can get around it with -Wno-pedantic-ms-format

mback2k added a commit to mback2k/curl that referenced this pull request Sep 9, 2021
@mback2k
CI: align make and test flags in various config files
ed28375 
1. Remove redundant parameters -a -p from target test-nonflaky.
2. Disable testing of SCP protocol on native Windows environments.
3. Use Makefile target to run tests in autotools builds on AppVeyor.
4. Don't use -vc parameter which is reserved for debugging.

Replaces curl#7591
@mback2k mback2k mentioned this pull request Sep 9, 2021
Closed
@mback2k
Copy link
Member Author

mback2k commented Sep 9, 2021

Keeping the branch with these changes around, but closing this PR in favor of #7690. Let's do one step at a time. Thanks @jay.

@mback2k mback2k closed this Sep 9, 2021
mback2k added a commit that referenced this pull request Sep 27, 2021
@mback2k
CI: align make and test flags in various config files
02c9802 
1. Use Makefile target to run tests in autotools builds on AppVeyor.
2. Disable testing of SCP protocol on native Windows environments.
3. Remove redundant parameters -a -p from target test-nonflaky.
4. Don't use -vc parameter which is reserved for debugging.

Replaces #7591
Closes #7690
mback2k added a commit to mback2k/curl that referenced this pull request Oct 29, 2021
@mback2k
CI: build examples for additional code verification
319c426 
Some CIs already build them, let's do it on more of them.

Follow up to curl#7690
Replaces curl#7591
@mback2k mback2k mentioned this pull request Oct 29, 2021
Closed
mback2k added a commit to mback2k/curl that referenced this pull request Nov 1, 2021
@mback2k
CI: build examples for additional code verification
41c32c4 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Nov 5, 2021
@mback2k
CI: build examples for additional code verification
0c429a8 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Nov 5, 2021
@mback2k
CI: build examples for additional code verification
f784edc 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Nov 6, 2021
@mback2k
CI: build examples for additional code verification
b5c1b67 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Nov 6, 2021
@mback2k
CI: build examples for additional code verification
a002951 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Nov 7, 2021
@mback2k
CI: build examples for additional code verification
f5b4298 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.
Improve size_t to long conversion in imap-append.c example.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Nov 8, 2021
@mback2k
CI: build examples for additional code verification
7b4c3ec 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.
Improve size_t to long conversion in imap-append.c example.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Nov 9, 2021
@mback2k
CI: build examples for additional code verification
f82e981 
Some CIs already build them, let's do it on more of them.

Follow up to curl#7690
Replaces curl#7591
mback2k added a commit to mback2k/curl that referenced this pull request Nov 9, 2021
@mback2k
CI: build examples for additional code verification
d1a2c88 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.
Improve size_t to long conversion in imap-append.c example.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Dec 11, 2021
@mback2k
CI: build examples for additional code verification
ed81eea 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.
Improve size_t to long conversion in imap-append.c example.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit to mback2k/curl that referenced this pull request Dec 13, 2021
@mback2k
CI: build examples for additional code verification
8c81ead 
Some CIs already build them, let's do it on more of them.

Ignore -Wformat while using GCC on mingw to compile examples.
Improve size_t to long conversion in imap-append.c example.

Ref: curl#6079
Ref: curl#6082
Assisted-by: Jay Satiro

Follow up to curl#7690
Replaces curl#7591
Closes curl#7922
mback2k added a commit that referenced this pull request Dec 14, 2021
@mback2k
CI: build examples for additional code verification
f03cc1b 
Some CIs already build them, let's do it on more of them.

Reviewed-by: Daniel Stenberg

Follow up to #7690 and 77311f4
Replaces #7591
Closes #7922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mback2k mback2k

Labels
CI Continuous Integration tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mback2k @jay