Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync values for HTTP_ONLY #7601

Closed
wants to merge 1 commit into from
Closed

Conversation

@donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Aug 20, 2021

The values for HTTP_ONLY differed between CMakeLists.txt and curl_setup.h. Sync them and sort the values in curl_setup.h to make it easier to spot differences.

The values for HTTP_ONLY differed between CMakeLists.txt and curl_setup.h. Sync them and sort the values in curl_setup.h to make it easier to spot differences.
@donny-dont
Copy link
Contributor Author

@donny-dont donny-dont commented Aug 20, 2021

If there are any additional options that should or shouldn't be in that listing let me know and I'll update it.

I just sorted it because its way easier to eyeball differences but I can roll that back too if that's an issue.

@jay jay added the build label Aug 21, 2021
@bagder
Copy link
Member

@bagder bagder commented Aug 21, 2021

The values for HTTP_ONLY differed

Did they? Your commit makes it look like the only thing that differed was the order? (I'm fine with sorting the order, I'm just curious about what I'm missing)

@donny-dont
Copy link
Contributor Author

@donny-dont donny-dont commented Aug 21, 2021

The values for HTTP_ONLY differed

Did they? Your commit makes it look like the only thing that differed was the order? (I'm fine with sorting the order, I'm just curious about what I'm missing)

CURL_DISABLE_MQTT was missing from the header. If anything else should also be there I’m happy to add the entries.

@bagder
Copy link
Member

@bagder bagder commented Aug 21, 2021

Ah right, didn't spot that!

bagder
bagder approved these changes Aug 21, 2021
@bagder
Copy link
Member

@bagder bagder commented Aug 21, 2021

Thanks!

@bagder bagder closed this in 4886962 Aug 21, 2021
@donny-dont donny-dont deleted the sync-http-only branch Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants