Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nss:set_cipher don't clobber the cipher list #8161

Closed
wants to merge 3 commits into from
Closed

nss:set_cipher don't clobber the cipher list #8161

wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Dec 17, 2021

The string is set by the user and needs to remain intact for proper
connection reuse etc.

Reported-by: Eric Musser
Fixes #8160

@bagder
nss:set_cipher don't clobber the cipher list
cb58e39 
The string is set by the user and needs to remain intact for proper
connection reuse etc.

Reported-by: Eric Musser
Fixes #8160
@bagder bagder added the TLS label Dec 17, 2021
@bagder bagder mentioned this pull request Dec 17, 2021
Closed
sfc-gh-emusser
sfc-gh-emusser reviewed Dec 17, 2021
View reviewed changes
Copy link

@sfc-gh-emusser sfc-gh-emusser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround! One minor issue with the change.

lib/vtls/nss.c Outdated Show resolved Hide resolved
@bagder
Copy link
Member Author

bagder commented Dec 18, 2021

@danielgustafsson I figured you've dabbled with NSS a bit so you might have an opinion on this?

@bagder bagder closed this in 556a42e Dec 20, 2021
@bagder bagder deleted the bagder/nss-noclobbe-ciphers branch December 20, 2021 09:52
sfc-gh-emusser pushed a commit to sfc-gh-emusser/curl that referenced this pull request Dec 22, 2021
@bagder @sfc-gh-emusser
nss:set_cipher don't clobber the cipher list
3b4c0ba 
The string is set by the user and needs to remain intact for proper
connection reuse etc.

Reported-by: Eric Musser
Fixes curl#8160
Closes curl#8161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-emusser sfc-gh-emusser sfc-gh-emusser left review comments

@jay jay jay approved these changes

@danielgustafsson danielgustafsson Awaiting requested review from danielgustafsson

Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connections not reused when cipher list specified
3 participants
@bagder @jay @sfc-gh-emusser