Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes strlen() calls per SAN name in a cert-check for chained certificates #8428

Closed
wants to merge 7 commits into from

Conversation

HenrikHolst
Copy link
Contributor

@HenrikHolst HenrikHolst commented Feb 10, 2022

Further to #8418 there is for chained certificates a strlen done on the hostname for each iteration of the loop through the chain. For e.g https://curl.se this leads to zero difference since the certificate used there is "sane" but for the https://google.com case which perhaps represents a worst case scenario we can reduce a further 108 calls to strlen.

bagder
bagder approved these changes Feb 13, 2022
@bagder
Copy link
Member

@bagder bagder commented Feb 13, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants