Removes strlen() calls per SAN name in a cert-check for chained certificates#8428
Closed
HenrikHolst wants to merge 7 commits into
Closed
Removes strlen() calls per SAN name in a cert-check for chained certificates#8428HenrikHolst wants to merge 7 commits into
HenrikHolst wants to merge 7 commits into
Conversation
bagder
approved these changes
Feb 13, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further to #8418 there is for chained certificates a strlen done on the hostname for each iteration of the loop through the chain. For e.g https://curl.se this leads to zero difference since the certificate used there is "sane" but for the https://google.com case which perhaps represents a worst case scenario we can reduce a further 108 calls to strlen.