Use correct buffer sizes for OpenSSL error messages #844

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mkauf
Contributor
mkauf commented May 31, 2016

No description provided.

@mkauf mkauf Use correct buffer sizes for OpenSSL error messages
b9f6fa0
@bagder
Member
bagder commented May 31, 2016

I think the more important change here is that you changed to using SSL_strerror instead of ERR_error_string. Why? The former function seems to be completely undocumented? When was that introduced? Is it meant to work the same way as ERR_error_string?

@bagder bagder added the SSL/TLS label May 31, 2016
@mkauf
Contributor
mkauf commented May 31, 2016

SSL_strerror is an internal libcurl function, implemented in lib/vtls/openssl.c :-)
It's a wrapper for OpenSSL's ERR_error_string_n

@bagder
Member
bagder commented May 31, 2016

Hah, look at that. I totally blanked on that... thanks!

@bagder
Member
bagder commented May 31, 2016

We should probably rename it to not use a "SSL_" prefix as some OpenSSL functions use that.

@bagder bagder closed this in 7108e53 May 31, 2016
@bagder
Member
bagder commented May 31, 2016

thanks!

@mkauf mkauf deleted the mkauf:OpenSSL_Buffer_Size branch May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment