Skip to content

Use correct buffer sizes for OpenSSL error messages - #844

Closed
mkauf wants to merge 1 commit into
curl:masterfrom
mkauf:OpenSSL_Buffer_Size
Closed

mkauf wants to merge 1 commit into
curl:masterfrom
mkauf:OpenSSL_Buffer_Size

Conversation

@mkauf

@mkauf mkauf commented May 31, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@bagder

bagder commented May 31, 2016

Copy link
Copy Markdown
Member

I think the more important change here is that you changed to using SSL_strerror instead of ERR_error_string. Why? The former function seems to be completely undocumented? When was that introduced? Is it meant to work the same way as ERR_error_string?

@bagder bagder added the TLS label May 31, 2016
@mkauf

mkauf commented May 31, 2016

Copy link
Copy Markdown
Contributor Author

SSL_strerror is an internal libcurl function, implemented in lib/vtls/openssl.c :-)
It's a wrapper for OpenSSL's ERR_error_string_n

@bagder

bagder commented May 31, 2016

Copy link
Copy Markdown
Member

Hah, look at that. I totally blanked on that... thanks!

@bagder

bagder commented May 31, 2016

Copy link
Copy Markdown
Member

We should probably rename it to not use a "SSL_" prefix as some OpenSSL functions use that.

@bagder bagder closed this in 7108e53 May 31, 2016
@bagder

bagder commented May 31, 2016

Copy link
Copy Markdown
Member

thanks!

@mkauf
mkauf deleted the OpenSSL_Buffer_Size branch May 31, 2016 18:05
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

2 participants