New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct buffer sizes for OpenSSL error messages #844

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mkauf
Contributor

mkauf commented May 31, 2016

No description provided.

@bagder

This comment has been minimized.

Member

bagder commented May 31, 2016

I think the more important change here is that you changed to using SSL_strerror instead of ERR_error_string. Why? The former function seems to be completely undocumented? When was that introduced? Is it meant to work the same way as ERR_error_string?

@bagder bagder added the SSL/TLS label May 31, 2016

@mkauf

This comment has been minimized.

Contributor

mkauf commented May 31, 2016

SSL_strerror is an internal libcurl function, implemented in lib/vtls/openssl.c :-)
It's a wrapper for OpenSSL's ERR_error_string_n

@bagder

This comment has been minimized.

Member

bagder commented May 31, 2016

Hah, look at that. I totally blanked on that... thanks!

@bagder

This comment has been minimized.

Member

bagder commented May 31, 2016

We should probably rename it to not use a "SSL_" prefix as some OpenSSL functions use that.

@bagder bagder closed this in 7108e53 May 31, 2016

@bagder

This comment has been minimized.

Member

bagder commented May 31, 2016

thanks!

@mkauf mkauf deleted the mkauf:OpenSSL_Buffer_Size branch May 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment