ngtcp2: Fix build error due to change in ngtcp2 prototypes #9748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The callback struct was extended as well |
diff --git a/lib/vquic/ngtcp2.c b/lib/vquic/ngtcp2.c
index e775c2fc8..14560d4c3 100644
--- a/lib/vquic/ngtcp2.c
+++ b/lib/vquic/ngtcp2.c
@@ -758,10 +758,11 @@ static ngtcp2_callbacks ng_callbacks = {
ngtcp2_crypto_get_path_challenge_data_cb,
cb_stream_stop_sending,
NULL, /* version_negotiation */
cb_recv_rx_key,
NULL, /* recv_tx_key */
+ NULL, /* early_data_rejected */
};
/*
* Might be called twice for happy eyeballs.
*/ |
bagder
approved these changes
Oct 17, 2022
ngtcp2/ngtcp2@b0d86f60 changed: - ngtcp2_conn_get_max_udp_payload_size => ngtcp2_conn_get_max_tx_udp_payload_size - ngtcp2_conn_get_path_max_udp_payload_size => ngtcp2_conn_get_path_max_tx_udp_payload_size ngtcp2/ngtcp2@ec59b873 changed: - 'early_data_rejected' member added to ng_callbacks. Assisted-by: Daniel Stenberg Reported-by: jurisuk@users.noreply.github.com Fixes curl#9747 Closes #xxxx
jquepi
pushed a commit
to jquepi/curl.1.555
that referenced
this pull request
Oct 24, 2022
ngtcp2/ngtcp2@b0d86f60 changed: - ngtcp2_conn_get_max_udp_payload_size => ngtcp2_conn_get_max_tx_udp_payload_size - ngtcp2_conn_get_path_max_udp_payload_size => ngtcp2_conn_get_path_max_tx_udp_payload_size ngtcp2/ngtcp2@ec59b873 changed: - 'early_data_rejected' member added to ng_callbacks. Assisted-by: Daniel Stenberg Reported-by: jurisuk@users.noreply.github.com Fixes curl/curl#9747 Closes curl/curl#9748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngtcp2/ngtcp2@b0d86f60 changed:
ngtcp2_conn_get_max_udp_payload_size =>
ngtcp2_conn_get_max_tx_udp_payload_size
ngtcp2_conn_get_path_max_udp_payload_size =>
ngtcp2_conn_get_path_max_tx_udp_payload_size
Reported-by: jurisuk@users.noreply.github.com
Fixes #9747
Closes #xxxx