New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance CURLOPT_FTP_SKIP_PASV_IP #9758
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,7 +177,8 @@ struct OperationConfig { | |
bool doh_verifystatus; | ||
bool create_dirs; | ||
bool ftp_create_dirs; | ||
bool ftp_skip_ip; | ||
long ftp_pasvp_ip_rule; /* how to handle the IP address the FTP server | ||
passes on to us */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you should keep treating this as a boolean cmdline option There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. original author permits 3 values, so I don't think bool would fit here. |
||
bool proxynegotiate; | ||
bool proxyntlm; | ||
bool proxydigest; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1198,7 +1198,7 @@ ParameterError getparameter(const char *flag, /* f or -long-flag */ | |
config->ignorecl = toggle; | ||
break; | ||
case 'q': /* --ftp-skip-pasv-ip */ | ||
config->ftp_skip_ip = toggle; | ||
config->ftp_pasvp_ip_rule = CURL_FTP_SKIP_PASV_IP_ALWAYS; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this breaks behavior for users who do |
||
break; | ||
case 'r': /* --ftp-method (undocumented at this point) */ | ||
config->ftp_filemethod = ftpfilemethod(config, nextarg); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should also mention from which version this option works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, but I guess @Zenju has better knowledge of what he wanted to do with this
PR