curl: make --xattr save the original URL

[bagder]

No description provided.

[bagder]

This causes a minor peculiarity: imagine we get URL A that redirects to B. This now saves the URL as A (formerly it used B).

The xattr code also saves the referer header. But the rreferer header only makes sense after a redirect, so right now this gets the referer from the second request... which happens to always be A if automatic referer is used!

[vszakats]

True. Well, auto-referrer might trigger to save the effective URL to the origin xattr, but this seems way more trouble than it's worth.

Perhaps the best solution is to just not use automatic referrers.

[ Off-topic: A generic solution could be a --write-out-like option where the user could customize what information to write to which xattr, e.g. --xattr-out 'user.xdg.origin.url=%{url_effective}'. New variables, like download timestamp or hash can be added to the list. --xattr would trigger the default set. ]

[bagder]

@mback2k the Appveyor builds now all appear as failed, but looking at the details there is no link to figure out more!

It appears as if it still shows the previous rounds build failure while in fact it has restarted a new build after the PR was updated. Can this be it?

[bagder]

No that was not it. It seems they were failed builds, but without links to the build logs.

[bagder]

Right, the new test does not work on Windows...

[vszakats]

You can just disable these tests for Windows. On Windows there are no xattrs. There is a similar feature called file streams, but there is no fsetxattr() API for it.

[bagder]

I figure there are more platforms than Windows without it, so I tried to make it a proper feature for the test suite to require.

[bagder]

Since #9769: while appveyor builds are running they show as failed jobs (with the red cross), and if you click details it shows the wrong commit (message)

[mback2k]

I will look at the AppVeyor issue tonight.