Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix some type mismatches and remove unneeded typecasts #9835

Closed
wants to merge 3 commits into from

Conversation

jay
Copy link
Member

@jay jay commented Oct 31, 2022

Many of these castings are unneeded if we change the variables to work better with each other.

Ref: #9823

Closes #xxxx


This is a subset of the changes submitted by @AtariDreams in #9823.

Many of these castings are unneeded if we change the variables to work
better with each other.

Ref: curl#9823

Closes #xxxx
lib/ftp.c Outdated Show resolved Hide resolved
lib/noproxy.c Outdated Show resolved Hide resolved
@@ -650,7 +650,7 @@ CURLcode Curl_http_auth_act(struct Curl_easy *data)
if(!data->set.str[STRING_BEARER])
authmask &= (unsigned long)~CURLAUTH_BEARER;

if(100 <= data->req.httpcode && 199 >= data->req.httpcode)
if(100 <= data->req.httpcode && data->req.httpcode <= 199)
Copy link
Member

@MarcelRaad MarcelRaad Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is supposed to fix. The rest looks good to me!

Copy link
Member Author

@jay jay Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one isn't supposed to fix anything it's just a style change.

@jay jay closed this in f151ec6 Nov 8, 2022
@jay jay deleted the pr_9823_modified branch Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants