nss: work around race condition in PK11_FindSlotByName #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialise the call to PK11_FindSlotByName in nss_create_object to avoid spurious errors in a multi-threaded environment. The underlying cause is a race condition in nssSlot_IsTokenPresent. There are other paths into nssSlot_IsTokenPresent which may potentially have the same problem, e.g. other calls to PK11_FindSlotByName, but this is one path for which we have a test case. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1297397
|
ping @kdudka, looks good to me, you agree? I'm sure we will have users on the NSS version with this bug for a long time so it is worth merging a private fix for it. |
|
Thanks for the patch! It looks good to me. Just two remarks:
|
|
Ok, I will make those changes next week. |
|
@wangp No problem, I can make the changes on your behalf as long as you are fine with the proposal. |
|
Yes, go ahead. I won't have time until next Wednesday. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialise the call to PK11_FindSlotByName in nss_create_object to avoid
spurious errors in a multi-threaded environment. The underlying cause
is a race condition in nssSlot_IsTokenPresent.
There are other paths into nssSlot_IsTokenPresent which may potentially
have the same problem, e.g. other calls to PK11_FindSlotByName, but this
is one path for which we have a test case.
Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1297397