Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: restore old msdos, amigaos makefiles #9984

Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Nov 27, 2022

  • Restore original legacy Makefiles for MS-DOS and AmigaOS. Some envs do not recognize double-quoted command-line arguments.
  • Status of MS-DOS/AmigaOS platform support inside Makefile.mk changes to experimental.

Regression from a8861b6 (Partial revert)

Reported-by: Gisle Vanem
Fixes #9764 (comment)
Closes #xxxx


The extra clutter in Makefile.mk that belong to these two platorms is quite tiny: 23 lines. Extra 30 lines for WIN32-specific stuff, which can be removed if we support Windows-only here.

[ Not saying that these couldn't be made work with Makefile.mk, but I don't have the capacity to test/support the needs of these platforms. Also, supporting them seems to be difficult without hurting legibility of mingw32-specific logic. ]

@vszakats vszakats changed the title [WIP] legacy: restore old msdos amiga makefiles [WIP] legacy: restore old msdos, amigaos makefiles Nov 27, 2022
@vszakats vszakats changed the title [WIP] legacy: restore old msdos, amigaos makefiles build: restore old msdos, amigaos makefiles Nov 27, 2022
@vszakats vszakats force-pushed the restore-old-msdos-amiga-makefiles branch from 0bc2b52 to 026372a Compare November 27, 2022 14:22
@vszakats
Copy link
Member Author

vszakats commented Nov 28, 2022

Pending discussions:

  • Why double quotes might not be working on Windows? → Mixing tools/shells with different quoting semantics, e.g. Cygwin with mingw32-make. Notice: Makefile.mk doesn't require Cygwin, and should work with the default Windows shell, and also MSYS2.
  • Dropping support for spaces in *_PATH variables? → Mixed opinions.
  • Use "-L<path>" style quoting? (vs. -L"<path>") → According to my fairly basic tests, this should not matter.

For now I'm siding this is a build environment problem and not a curl Makefile.mk issue.

@vszakats vszakats added not-a-bug This is not a bug in curl and removed regression labels Nov 29, 2022
@vszakats
Copy link
Member Author

Closing with these conclusions/notes: #9764 (comment)

@vszakats vszakats closed this Nov 29, 2022
@vszakats vszakats deleted the restore-old-msdos-amiga-makefiles branch February 2, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build not-a-bug This is not a bug in curl
Development

Successfully merging this pull request may close these issues.

None yet

1 participant