New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test fails if built against libcurl 8.3.0 #239
Comments
Hmmm it looks like something in url api may have changed in the recent curl release? If I build trurl against an older version the tests pass but when I build against 8.3.0 the tests fail in the same way described by @abbbi and our github actions use a pretty old version of curl so that's why it wasn't caught earlier. |
the changed behavior is caused by following commit in curl url api: fix for: reverting this one in libcurl and linking trurl against shields the old behavior:
|
It is simply getting a different error message. diff --git a/tests.json b/tests.json
index 8222c14..fe48b6c 100644
--- a/tests.json
+++ b/tests.json
@@ -1488,7 +1488,7 @@
}
],
"returncode": 9,
- "stderr": "trurl error: No host part in the URL []\ntrurl error: Try trurl -h for help\n"
+ "stderr": true
}
},
{
@@ -1744,7 +1744,7 @@
"expected": {
"stdout": "emanuele6://curl.se/trurl\nhttps://example.org/\n",
"returncode": 0,
- "stderr": "trurl note: No host part in the URL []\n"
+ "stderr": true
}
},
{
This is already supported by the test runner, and will be satisfied if the command results in anything being written to |
Changes in libcurl 8.3.0 make some testcases fail due to different error message wording. Adjust testcases so only the presence of an stderr is verified, not the wording in detail.
Changes in libcurl 8.3.0 make some testcases fail due to different error message wording. Adjust testcases so only the presence of an stderr is verified, not the wording in detail.
@emanuele6 thanks, i just added this patch to the debian package for now. PR (#240) |
hi there,
debian QA team has scheduled an archive wide rebuild and it seems trurl fails within its testsuite
on debian/sid:
and:
full report:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1052828
It seems (for whatever reason) the output of trurl in stderr is not the one expected in the testsuite
for both cases and i can reproduce:
The text was updated successfully, but these errors were encountered: