added automatic build and upload of artifacts #177
Conversation
|
probably you'd like to rename "windows" in "cygwin", as it's that, really (i just extended your own github action with the release part) |
|
I presume these Windows build binaries only work if you have cygwin installed? Then I agree they should be named cygwin. |
They're just the same builds already in original automation, just added the release and publish part... |
| on: | ||
| push: | ||
| tags: | ||
| - "v*" |
There was a problem hiding this comment.
Is this supposed to match the tags for which to make releases? They are named trurl-* now...
There was a problem hiding this comment.
This automation is triggered only when you push a git tag, in my case I pushed v0.6.0, it's a standard way in gh actions, but you can modify as you want... It makes sense to me, as this way the binaries are created just on a new release, not always
|
We should probably also call them "ubuntu" rather than just "linux". |
|
Rename them yourself? Or do you want me to do? Just swap windows for cygwin |
I don't think that answers my question though? |
|
Lol, I'm just using what you yourself had made, I just renamed (wrongly) cygwin to windows, before realising that without the dll they don't work, of course |
I didn't even take a look on HOW did you build them: if it's a static build, with no dependencies, this should work everywhere on any linux, I'm not able of help you on this... |
But I talked about if not a rename would make sense. I did not ask you to change the build. |
It makes sense if these are, really, just ubuntu builds... If the biraries work on other distros, it's good to have them called linux, otherwise better rename them to ubuntu (really, a specific one, too...) For the windows ones, better rename windows to cygwin But I see a new pr of someone who probably made native windows builds, too |
|
i renamed both linux-->ubuntu and windows-->cygwin |
|
I think the biggest need for this is for native Windows builds, and I also did not manage to get this to work in a local test repo of mine. I think we can put this on hold for now. |
|
as windows was never a priority for me, and its buids were in your own code (if working or not, you know...), why not just incorporate the PR parts relative to the *nix builds, and strip out the win part? and my builds were perfectly fine as you can see here, just the win part failed, as expected (i don't know how to fix them nor interested into) |
it will automatically create a release when a new tag is pushed